That package had a dumb error in it, I've since fixed it and against a
live API (GoDaddy). I've tested the following scenarios

- Applying a custom proxy via the environment variable
- Using libcloud.security to disable SSL verification
- Using libcloud.security to set a custom CA certificate
- Combining all of those scenarios
- Verification of custom headers applied by the driver using Charles
Proxy and inspecting the HTTP messages manually
- Decoding JSON messages - although this still uses the existing
methods, not the requests own json() decoder.

IMO, this is ready to merge. I would like to test the raw connections
and file uploads if anyone has an account on one of those providers?

On Thu, Jan 5, 2017 at 8:30 AM, Tomaz Muraus <to...@apache.org> wrote:
> Thanks for working on this again!
>
> Once we get a green light from people testing those changes, I propose to
> first roll out v2.0.0-rc1 and eventually after we are happy with the
> stability call it v2.0.0.
>
> On Wed, Jan 4, 2017 at 6:20 AM, anthony shaw <anthony.p.s...@gmail.com>
> wrote:
>
>> Hi,
>>
>> I tried doing this a year ago but put it in the 'too hard' bucket.
>> I've opened a PR (again) replacing the use of httplib with the
>> requests package.
>>
>> The consequences are:
>> - Connection.conn_classes is no longer a tuple, it is
>> Connection.conn_class. There is no separation between a HTTP and HTTPS
>> connection. I could have just hacked around this but I updated all the
>> tests instead
>> - Mock implementations no longer use the tuple as above
>> - We cannot support Python 3.2 officially anymore. Requests does not
>> support 3.2
>> - The raw connection still uses httplib. I decided it was too risky to
>> swap that for requests' method of uploading files.
>>
>> https://github.com/apache/libcloud/pull/923#partial-pull-merging
>>
>> Please remote fetch this branch and test it out on some working code
>> talking to real APIs. Mocks can only go so far.
>>
>> I've uploaded the package here -
>> http://people.apache.org/~anthonyshaw/libcloud/1.5.0.post0/
>>
>> I would like to get this merged but would like some additional nods
>> before it gets merged into trunk.
>>
>> Ant
>>

Reply via email to