that's now been fixed, the other issue someone raised is the Linode driver.
Since the LinodeResponse class doesn't call super on __init__, it has a whole copy+paste (with bugs) of the Response initializer. Seems to just be some old legacy code https://github.com/apache/libcloud/blame/trunk/libcloud/common/linode.py#L68 yuck. The linode one needs to be fixed separately and merged into this one https://github.com/apache/libcloud/pull/1025 Then I will have to restart the release process. [-1] Release Apache Libcloud 2.0.0rc2 On Thu, Apr 6, 2017 at 8:39 AM, anthony shaw <anthony.p.s...@gmail.com> wrote: > OK, that code shouldn't be there anymore, requests handles decompression > (well, urllib3 does) > > Infact, the whole module libcloud.utils.compression is no longer needed, > the libcloud.common.base private method def _decompress_response(self, > body, headers) can never be called. > > I'll try and repro in a test and fix it. It only impacts the scenario of > LIBCLOUD_DEBUG for compressed responses. > > On Thu, Apr 6, 2017 at 2:33 AM, Tom Melendez <t...@supertom.com> wrote: > >> HI Anthony, >> >> Thanks for pulling this together. >> >> I found an issue involving LIBCLOUD_DEBUG (that I haven't had time to >> investigate): https://issues.apache.org/jira/browse/LIBCLOUD-910 >> >> I would have to vote No until we resolve it. >> >> [-1] Release Apache Libcloud 2.0.0rc2 >> * tox: OK >> * gce_demo: OK >> * export LIBCLOUD_DEBUG: not OK >> >> Thanks, >> >> Tom >> >> On Sat, Apr 1, 2017 at 8:01 PM, anthony shaw <anthony.p.s...@gmail.com> >> wrote: >> >> > This is a voting thread for Libcloud 2.0.0rc2 >> > >> > This is a release candidate for 2.0 and contains major changes since the >> > latest stable release, 1.5.0, >> > http://libcloud.readthedocs.io/en/latest/other/changes_in_2_0.html >> > >> > The rc1 release did not pass, with issues on custom port propagation, >> > logging/debug mode and certificate connection drivers. Those have >> > independently been fixed and tested over the past couple of months. All >> of >> > the issues raised both on the developer group and on the ASF issues log >> > have been resolved related to the 2.0x changes. >> > >> > Specific bug fix changes since rc1 include >> > >> > - Fixing of Logging/debug connection >> > - Fixing of Certificate connection (and azure and openstack drivers) >> > >> > A new -tentative tag is committed and can be found at >> > https://git-wip-us.apache.org/repos/asf?p=libcloud.git;a= >> > tag;h=refs/tags/v2.0.0rc2-tentative >> > >> > A full list of changes can be found at: >> > *https://git-wip-us.apache.org/repos/asf?p=libcloud.git; >> > a=blob;f=CHANGES.rst;h=a996cb82f39895c0b3566907cd947027b674c725;hb= >> > 623fa89bedb1e37d1546936c78583867aed23057 >> > <https://git-wip-us.apache.org/repos/asf?p=libcloud.git; >> > a=blob;f=CHANGES.rst;h=a996cb82f39895c0b3566907cd947027b674c725;hb= >> > 623fa89bedb1e37d1546936c78583867aed23057>* >> > >> > Major changes include >> > >> > - Replaced urllib with requests >> > >> > Minor changes include >> > >> > - Fix vSphere driver >> > - Enabling HTTP redirects by default >> > - Allowing both global and driver-specific HTTP proxy configuration >> > - Consolidation of the LibcloudHTTPSConnection and >> > LibcloudHTTPConnection into a single class, LibcloudConnection >> > - Support for streaming responses >> > - Support for mocking HTTP responses without having to mock the >> Connection >> > class >> > - 10% typical performance improvement with the use of persistent TCP >> > connections for each driver instance >> > - Access to the low-level TCP session is no longer available. Access >> > to .read() on a raw connection will bind around requests body or >> > iter_content methods. >> > >> > >> > Release artifacts can be found at >> > http://people.apache.org/~anthonyshaw/libcloud/2.0.0rc >> > <http://people.apache.org/~anthonyshaw/libcloud/2.0.0rc2/>2/ >> > >> > Note that KEYS file can found at >> > https://dist.apache.org/repos/dist/release/libcloud/KEYS >> > >> > Please test the release and post your votes. >> > >> > +/- 1 >> > [ ] Release Apache Libcloud 2.0.0rc2 >> > >> > Vote will be open until April 7th, 2017. >> > >> > Thanks, >> > Anthony >> > >> > >
