This PR is now finished. https://github.com/apache/libcloud/pull/1031
It uncovered 3 issues as documented on the PR. The Azure one is still unresolved. Also, coveralls is reactivated in the build pipeline. We get coverage numbers in PRs again. Also we can see which drivers have little or no tests. Anthony Shaw ________________________________ From: anthony shaw <[email protected]> Sent: Wednesday, April 12, 2017 3:44:31 PM To: dev Subject: Replacing the HTTP mocks Hi, I mentioned this a while back, but I've gotten around to ripping out the HTTPlib mocks that existed in libcloud.test why? Because they were mocks stacked on mocks, they didn't represent the actual behaviour of the old or new system and I thought they might be hiding some bugs. This change uses the requests_mock package to take the response of the MockHttp method and load it into the requests transport. So it goes through the entire class subsystem for libcloud.http. This increases our test coverage overall and might catch some weird errors. Well, it was a good suspicion. https://github.com/apache/libcloud/pull/1031 * headers- some of the drivers attempt to send HTTP headers as integers. this is invalid in requests (and in general, all should be strings). I picked up a number of bugs here * backblaze_b2 storage, the download_object_as_stream method is incompatible with the API, so probably doesn't work * vsphere is totally broken, but now "fixed" as far as unit testing is concerned. It would have bombed out here https://github.com/apache/libcloud/pull/1031/files#diff-7acbd31b698c80ee037fd8ca2db0a965L343 * I've got some real concerns about the cloudfiles driver. (it used to be called MossoFS) I don't know if anyone still uses this or if the service is still online. I'm still going. Down to 50 broken tests (from 996 this morning!)
