Hi again,

I’ve found another issue when trying to upgrade to libcloud-2.0.0.

GCENodeDriver.create_volume() has an optional ‘location’ parameter that, 
according to the docs, can be of type ‘str’, ‘GCEZone’ or ‘NodeLocation’. If 
something other than a str is passed as argument, the call fails in 
libcloud-2.0.0 (worked fine in 1.3.0, the bug was introduced when adding a dict 
of cached volumes).

Before working on a fix, I’d like to ask you first which option you prefer:
1) Leave the code as-is and fix the documentation; or
2) Leave the documentation as-is and fix the code.

I think (2) is better because it maintains api compatibility with previous 
libcloud versions. Please let me know your opinion.

Btw, when looking into this I noticed that a non-existent method of the same 
driver was being invoked: https://github.com/apache/libcloud/pull/1046

Best,
--
Francisco J. Ros

Reply via email to