Nice work - all of those are good catches. It would be great if you could add corresponding test cases so we can avoid such performance regressions in the future.
Once that + changelog entries are done, I think it would be a good idea to roll out v2.2.2 with those fixes :) On Tue, Oct 31, 2017 at 5:35 AM, Quentin Pradet <quentin.pra...@gmail.com> wrote: > Hello, > > I have a few pending pull requests waiting for review. Can anyone please > look at them and tell me what they think? The first two ones are the most > important, and we actually use them in production today. > > - #1135 <https://github.com/apache/libcloud/pull/1135>storage: Fix hash > computation performance on upload > <https://github.com/apache/libcloud/pull/1135> > - #1132 Ensure RawResponse downloads don't consume RAM > <https://github.com/apache/libcloud/pull/1132> > - #1133 Fix improper getresponse() uses > <https://github.com/apache/libcloud/pull/1133> > > Thanks, > Quentin >