This is an automated email from the ASF dual-hosted git repository. jbonofre pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-liminal.git
commit ae36a5ee373caf9b264ac7bad68bf14f0875c6d1 Author: aviemzur <[email protected]> AuthorDate: Thu Mar 12 12:14:25 2020 +0200 Remove TODOs with GitHub issues --- rainbow/build/build_rainbows.py | 2 -- rainbow/http/__init__.py | 1 - rainbow/monitoring/__init__.py | 1 - rainbow/runners/airflow/dag/rainbow_dags.py | 4 +--- rainbow/runners/airflow/tasks/create_cloudformation_stack.py | 2 +- rainbow/runners/airflow/tasks/delete_cloudformation_stack.py | 2 +- rainbow/runners/airflow/tasks/job_end.py | 2 +- rainbow/runners/airflow/tasks/job_start.py | 3 +-- rainbow/runners/airflow/tasks/spark.py | 2 +- rainbow/runners/airflow/tasks/sql.py | 2 +- rainbow/sql/__init__.py | 1 - 11 files changed, 7 insertions(+), 15 deletions(-) diff --git a/rainbow/build/build_rainbows.py b/rainbow/build/build_rainbows.py index d10a9bc..1452bb8 100644 --- a/rainbow/build/build_rainbows.py +++ b/rainbow/build/build_rainbows.py @@ -35,7 +35,6 @@ def build_rainbows(path): print(f'Building artifacts for file: {config_file}') with open(config_file) as stream: - # TODO: validate config config = yaml.safe_load(stream) for pipeline in config['pipelines']: @@ -47,7 +46,6 @@ def build_rainbows(path): tag=task['image']) -# TODO: build class registry build_classes = { 'python': PythonImage } diff --git a/rainbow/http/__init__.py b/rainbow/http/__init__.py index d723ae2..217e5db 100644 --- a/rainbow/http/__init__.py +++ b/rainbow/http/__init__.py @@ -15,4 +15,3 @@ # KIND, either express or implied. See the License for the # specific language governing permissions and limitations # under the License. -# TODO: http diff --git a/rainbow/monitoring/__init__.py b/rainbow/monitoring/__init__.py index 8df8694..217e5db 100644 --- a/rainbow/monitoring/__init__.py +++ b/rainbow/monitoring/__init__.py @@ -15,4 +15,3 @@ # KIND, either express or implied. See the License for the # specific language governing permissions and limitations # under the License. -# TODO: monitoring diff --git a/rainbow/runners/airflow/dag/rainbow_dags.py b/rainbow/runners/airflow/dag/rainbow_dags.py index 639f0cc..8557455 100644 --- a/rainbow/runners/airflow/dag/rainbow_dags.py +++ b/rainbow/runners/airflow/dag/rainbow_dags.py @@ -38,7 +38,6 @@ def register_dags(configs_path): print(f'Registering DAG for file: f{config_file}') with open(config_file) as stream: - # TODO: validate config config = yaml.safe_load(stream) for pipeline in config['pipelines']: @@ -48,7 +47,7 @@ def register_dags(configs_path): 'owner': config['owner'], 'start_date': datetime.combine(pipeline['start_date'], datetime.min.time()) } - # TODO: add all relevant airflow args + dag = DAG( dag_id='test_dag', default_args=default_args @@ -67,7 +66,6 @@ def register_dags(configs_path): return dags -# TODO: task class registry task_classes = { 'python': PythonTask } diff --git a/rainbow/runners/airflow/tasks/create_cloudformation_stack.py b/rainbow/runners/airflow/tasks/create_cloudformation_stack.py index ca8482a..8f069f3 100644 --- a/rainbow/runners/airflow/tasks/create_cloudformation_stack.py +++ b/rainbow/runners/airflow/tasks/create_cloudformation_stack.py @@ -21,7 +21,7 @@ from rainbow.runners.airflow.model import task class CreateCloudFormationStackTask(task.Task): """ - # TODO: Creates cloud_formation stack. + Creates cloud_formation stack. """ def __init__(self, dag, pipeline_name, parent, config, trigger_rule): diff --git a/rainbow/runners/airflow/tasks/delete_cloudformation_stack.py b/rainbow/runners/airflow/tasks/delete_cloudformation_stack.py index 8ac4e8b..ab99101 100644 --- a/rainbow/runners/airflow/tasks/delete_cloudformation_stack.py +++ b/rainbow/runners/airflow/tasks/delete_cloudformation_stack.py @@ -21,7 +21,7 @@ from rainbow.runners.airflow.model import task class DeleteCloudFormationStackTask(task.Task): """ - # TODO: Deletes cloud_formation stack. + Deletes cloud_formation stack. """ def __init__(self, dag, pipeline_name, parent, config, trigger_rule): diff --git a/rainbow/runners/airflow/tasks/job_end.py b/rainbow/runners/airflow/tasks/job_end.py index 53e1eef..42b5e7f 100644 --- a/rainbow/runners/airflow/tasks/job_end.py +++ b/rainbow/runners/airflow/tasks/job_end.py @@ -21,7 +21,7 @@ from rainbow.runners.airflow.model import task class JobEndTask(task.Task): """ - # TODO: Job end task. Reports job end metrics. + Job end task. Reports job end metrics. """ def __init__(self, dag, pipeline_name, parent, config, trigger_rule): diff --git a/rainbow/runners/airflow/tasks/job_start.py b/rainbow/runners/airflow/tasks/job_start.py index 5c82e1c..64a2f4a 100644 --- a/rainbow/runners/airflow/tasks/job_start.py +++ b/rainbow/runners/airflow/tasks/job_start.py @@ -21,12 +21,11 @@ from rainbow.runners.airflow.model import task class JobStartTask(task.Task): """ - # TODO: Job start task. Reports job start metrics. + Job start task. Reports job start metrics. """ def __init__(self, dag, pipeline_name, parent, config, trigger_rule): super().__init__(dag, pipeline_name, parent, config, trigger_rule) def apply_task_to_dag(self): - # TODO: job start task pass diff --git a/rainbow/runners/airflow/tasks/spark.py b/rainbow/runners/airflow/tasks/spark.py index 5822e92..9a46dd4 100644 --- a/rainbow/runners/airflow/tasks/spark.py +++ b/rainbow/runners/airflow/tasks/spark.py @@ -21,7 +21,7 @@ from rainbow.runners.airflow.model import task class SparkTask(task.Task): """ - # TODO: Executes a Spark application. + Executes a Spark application. """ def __init__(self, dag, pipeline_name, parent, config, trigger_rule): diff --git a/rainbow/runners/airflow/tasks/sql.py b/rainbow/runners/airflow/tasks/sql.py index 42c02ce..7ae3b9f 100644 --- a/rainbow/runners/airflow/tasks/sql.py +++ b/rainbow/runners/airflow/tasks/sql.py @@ -21,7 +21,7 @@ from rainbow.runners.airflow.model import task class SparkTask(task.Task): """ - # TODO: Executes an SQL application. + Executes an SQL application. """ def __init__(self, dag, pipeline_name, parent, config, trigger_rule): diff --git a/rainbow/sql/__init__.py b/rainbow/sql/__init__.py index 495bf9c..217e5db 100644 --- a/rainbow/sql/__init__.py +++ b/rainbow/sql/__init__.py @@ -15,4 +15,3 @@ # KIND, either express or implied. See the License for the # specific language governing permissions and limitations # under the License. -# TODO: SQL (Scala? Python?)
