assapin commented on a change in pull request #3:
URL: https://github.com/apache/incubator-liminal/pull/3#discussion_r510237929
##########
File path: tests/runners/airflow/demo/model_store.py
##########
@@ -0,0 +1,45 @@
+import pickle
+import time
+
+import boto3
+
+BUCKET = 'ni-ml-ab-dev'
Review comment:
how will this example work for users? in terms of requiring S3 buckets
to exist etc.?
##########
File path: tests/runners/airflow/demo/serving.py
##########
@@ -0,0 +1,16 @@
+import json
+
+import model_store
+from model_store import ModelStore
+
+_MODEL_STORE = ModelStore(model_store.PRODUCTION)
+_PETAL_WIDTH = 'petal_width'
+
+
+def predict(input_json):
Review comment:
suggest to name the file prediction.py or inference.py
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
