This is an automated email from the ASF dual-hosted git repository.

assafpinhasi pushed a commit to branch official_docker
in repository https://gitbox.apache.org/repos/asf/incubator-liminal.git


The following commit(s) were added to refs/heads/official_docker by this push:
     new 6ec1d00  few deployment tweaks
6ec1d00 is described below

commit 6ec1d0016d726da336991dc1d7b22b0a029e34e5
Author: Assaf Pinhasi <[email protected]>
AuthorDate: Mon Nov 2 17:58:58 2020 +0200

    few deployment tweaks
---
 MANIFEST.in    |  1 -
 dev/RELEASE.md | 15 ++++++++++++---
 dev/sign.sh    |  0
 setup.py       |  2 ++
 4 files changed, 14 insertions(+), 4 deletions(-)

diff --git a/MANIFEST.in b/MANIFEST.in
index 74f3133..c6db8dd 100644
--- a/MANIFEST.in
+++ b/MANIFEST.in
@@ -17,5 +17,4 @@
 # under the License.
 
 include scripts/*
-include ./requirements-airflow.txt
 recursive-include liminal/build/ *
\ No newline at end of file
diff --git a/dev/RELEASE.md b/dev/RELEASE.md
index 5e3c239..97acde4 100644
--- a/dev/RELEASE.md
+++ b/dev/RELEASE.md
@@ -19,9 +19,12 @@
 <!-- START doctoc generated TOC please keep comment here to allow auto update 
-->
 <!-- DON'T EDIT THIS SECTION, INSTEAD RE-RUN doctoc TO UPDATE -->
 
+
 - [Apache Liminal source releases](#apache-liminal-source-releases)
   - [Apache Liminal Package](#apache-liminal-package)
 - [Prerequisites for the release manager preparing the 
release](#prerequisites-for-the-release-manager-preparing-the-release)
+  - [version IDs](#version-ids)
+  - [Testing the release locally](#testing-the-release-locally)
   - [Upload Public keys to id.apache.org](#upload-public-keys-to-idapacheorg)
   - [Configure PyPI uploads](#configure-pypi-uploads)
   - [Hardware used to prepare and verify the 
packages](#hardware-used-to-prepare-and-verify-the-packages)
@@ -80,6 +83,10 @@ to be committer to assume the release manager role, but 
there are final steps in
 final releases to SVN) that can only be done by PMC member. If needed, the 
release manager
 can ask PMC to perform that final step of release.
 
+## version IDs
+
+Should follow https://www.python.org/dev/peps/pep-0440/
+
 ## Testing the release locally
 
 - Build a local version of liminal:
@@ -231,7 +238,8 @@ cd incubating-liminal
 - Tag your release
 
 ```bash
-git tag -s ${LIMINAL_BUILD_VERSION}
+git tag -a ${LIMINAL_BUILD_VERSION} -m "some message"
+
 ```
 
 - Clean the checkout: the sdist step below will
@@ -259,8 +267,9 @@ python setup.py sdist bdist_wheel
 - Generate SHA512/ASC (If you have not generated a key yet, generate it by 
following instructions on 
http://www.apache.org/dev/openpgp.html#key-gen-generate-key)
 
 ```bash
-dev/sign.sh apache-liminal-${LIMINAL_BUILD_VERSION}.tar.gz
-dev/sign.sh apache_liminal-${LIMINAL_BUILD_VERSION}-py3-none-any.whl
+dev/sign.sh apache-liminal-${LIMINAL_BUILD_VERSION}-source.tar.gz
+dev/sign.sh dist/apache-liminal-${LIMINAL_BUILD_VERSION}.tar.gz
+dev/sign.sh dist/apache_liminal-${LIMINAL_BUILD_VERSION}-py3-none-any.whl
 ```
 
 - Push Tags
diff --git a/dev/sign.sh b/dev/sign.sh
old mode 100644
new mode 100755
diff --git a/setup.py b/setup.py
index 00286be..69d9a85 100644
--- a/setup.py
+++ b/setup.py
@@ -28,10 +28,12 @@ with open('requirements.txt') as f:
     requirements = f.read().splitlines()
     print(requirements)
 
+
 setuptools.setup(
     name="apache-liminal",
     version=os.environ.get("LIMINAL_BUILD_VERSION", 
os.environ.get('LIMINAL_VERSION', None)),
     author="[email protected]",
+    author_email='[email protected]',
     description="A package for authoring and deploying machine learning 
workflows",
     long_description=long_description,
     long_description_content_type="text/markdown",

Reply via email to