aviemzur commented on a change in pull request #46:
URL: https://github.com/apache/incubator-liminal/pull/46#discussion_r651811056
##########
File path: examples/aws-ml-app-demo/liminal.yml
##########
@@ -1,22 +1,30 @@
---
name: MyDataScienceApp
owner: Bosco Albert Baracus
+volumes:
+ - volume: gettingstartedvol
+ claim_name: gettingstartedvol-pvc
+ local:
+ path: .
images:
- image: myorg/mydatascienceapp
type: python
- source: .
services:
- service:
name: my_datascience_server
type: python_server
description: my ds server
image: myorg/mydatascienceapp
+ source: .
endpoints:
- endpoint: /predict
module: serving
function: predict
+ - endpoint: /healthcheck
+ module: serving
+ function: healthcheck
pipelines:
- - pipeline: my_datascience_pipeline
+ - pipeline: my_datascience_server
Review comment:
I'm confused by this change, why is `server` now part of the pipeline
name?
##########
File path: examples/aws-ml-app-demo/liminal.yml
##########
@@ -1,22 +1,30 @@
---
name: MyDataScienceApp
owner: Bosco Albert Baracus
+volumes:
+ - volume: gettingstartedvol
+ claim_name: gettingstartedvol-pvc
+ local:
+ path: .
images:
- image: myorg/mydatascienceapp
type: python
- source: .
services:
Review comment:
Why was source removed here?
##########
File path: examples/aws-ml-app-demo/model_store.py
##########
@@ -26,20 +25,16 @@ def load_latest_model(self, force=False):
return self._latest_model, self._latest_version
def save_model(self, model, version):
- pickle.dump(model, open("/tmp/model.p", "wb"))
+ s3_key = 'model.p'
+ s3_dir = f'{MOUNT_PATH}/{self.env}/{version}'
Review comment:
let's rename from s3 since uses mount and not s3
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
