assapin commented on a change in pull request #68:
URL: https://github.com/apache/incubator-liminal/pull/68#discussion_r693462909
##########
File path: install.sh
##########
@@ -19,27 +19,18 @@
DIR="$( cd "$( dirname "${BASH_SOURCE[0]}" )" >/dev/null 2>&1 && pwd )"
-if ! command -v liminal &> /dev/null
-then
- liminal stop
-fi
-
yes | pip uninstall apache-liminal
cd "$DIR" || exit
rm -rf build
rm -rf dist
+rm "${LIMINAL_HOME:-${HOME}/liminal_home}"/*.whl
Review comment:
so you want the install to put the .whl in liminal home?
##########
File path: scripts/Dockerfile-airflow
##########
@@ -21,11 +21,12 @@ FROM apache/airflow:1.10.12-python3.6
ARG LIMINAL_VERSION='apache-liminal'
ARG DAG_FOLDER='/opt/airflow/dags/'
ADD scripts/* ${DAG_FOLDER}
+ADD *.whl ${DAG_FOLDER}
Review comment:
this line takes .whl files from the docker context root.
Are you sure this is where you expect them to be? vs. in the liminal home or
wherever else you decided to place them?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
