aviemzur commented on a change in pull request #73:
URL: https://github.com/apache/incubator-liminal/pull/73#discussion_r805332192
##########
File path: liminal/build/image/python_server/liminal_python_server.py
##########
@@ -45,6 +45,12 @@ def __get_endpoint_function(endpoint_config):
blueprint = Blueprint('liminal_python_server_blueprint', __name__)
+
Review comment:
```suggestion
```
##########
File path: liminal/build/image/python_server/liminal_python_server.py
##########
@@ -45,6 +45,12 @@ def __get_endpoint_function(endpoint_config):
blueprint = Blueprint('liminal_python_server_blueprint', __name__)
+
+ @blueprint.route('/favicon.ico', methods=('GET', 'POST'))
+ def no_content():
+ return '', 204
+
+
Review comment:
```suggestion
```
##########
File path: liminal/build/image/python_server/liminal_python_server.py
##########
@@ -53,6 +59,7 @@ def show(endpoint):
else:
return 'Page not found.', 404
+
Review comment:
```suggestion
```
##########
File path:
tests/runners/airflow/build/http/python/test_python_server_image_builder.py
##########
@@ -96,6 +96,11 @@ def __test_build_python_server(self, use_pip_conf=False,
python_version=None):
self.assertEqual(f'Input was: {json.loads(json_string)}',
server_response)
+ server_favicon_response = urllib.request.urlopen(
Review comment:
```suggestion
server_favicon_response =
urllib.request.urlopen('http://localhost:9294/favicon.ico')
```
##########
File path:
tests/runners/airflow/build/http/python/test_python_server_image_builder.py
##########
@@ -96,6 +96,11 @@ def __test_build_python_server(self, use_pip_conf=False,
python_version=None):
self.assertEqual(f'Input was: {json.loads(json_string)}',
server_response)
+ server_favicon_response = urllib.request.urlopen(
+ 'http://localhost:9294/favicon.ico')
Review comment:
```suggestion
```
##########
File path: liminal/build/image/python_server/liminal_python_server.py
##########
@@ -17,7 +17,7 @@
# under the License.
import yaml
-from flask import Blueprint, Flask, request
+from flask import Flask, request, Blueprint
Review comment:
```suggestion
from flask import Blueprint, Flask, request
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
