lordk911 commented on a change in pull request #1058:
URL: https://github.com/apache/incubator-linkis/pull/1058#discussion_r740696777
##########
File path:
linkis-commons/linkis-common/src/main/java/org/apache/linkis/common/io/Fs.java
##########
@@ -52,4 +52,8 @@
public abstract boolean renameTo(FsPath oldDest, FsPath newDest) throws
IOException;
+ public abstract boolean mkdir(FsPath dest) throws IOException;
Review comment:
interface Fs in module linkis-common have a direct implement abstract
class FileSystem in module linkis-storage. The method add into Fs have already
IN FileSystem before this PR
##########
File path:
linkis-commons/linkis-common/src/main/java/org/apache/linkis/common/io/Fs.java
##########
@@ -52,4 +52,8 @@
public abstract boolean renameTo(FsPath oldDest, FsPath newDest) throws
IOException;
+ public abstract boolean mkdir(FsPath dest) throws IOException;
Review comment:
I have remove the the abstract method mkdir\mkdirs from abstract class
FileSystem and lift them to interface
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@linkis.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@linkis.apache.org
For additional commands, e-mail: dev-h...@linkis.apache.org
