————— 2022-5-27 ————— case 12:08 hive upgrade Consider a unified upgrade from 2.3.3 to 2.3.4. This may require an assessment of the possible impact points on existing upstream users.
case 12:09 ? case 12:09 you mean this Mr. Lightning 12:10 Yes Mr. Lightning 12:10 I can only compile if I comment out these two lines case 12:16 The differences between the major versions of Hive are still relatively large. You can record an issue that adapts to Hive version 1.1.0 as an adaptation guide. Or you can maintain a patch branch in your repository for reference by users who need it peacewong@WDS 12:16 Brother Hua Jin suggested that a PR optimization be mentioned here, instead of doing a forced conversion, instead, get String.valueOf directly. There should be no compatibility issues. peacewong@WDS 12:17 The result should be the same, no need to force Casion 12:21 I look at the modification record, it seems to be a specially fixed bug and the forced transfer peacewong@WDS 12:23 It feels like there is no need to optimize it. peacewong@WDS 12:24 There is no need to throw an exception here: ————— 2022-5-27 ————— casion 12:08 hive升级 可以考虑从2.3.3 统一升级至2.3.4 这个可能需要先评估下 对上游已有用户可能存在的影响点。 casion 12:09 ？ casion 12:09 你指的是这个 闪电先生 12:10 是的 闪电先生 12:10 我只有注释掉这二行才能编译 casion 12:16 Hive大版本之间差异还是比较大，可以录一个适配hive 1.1.0版本的issue，作为适配指引。或则可以在你仓库维护一个patch分支，供需要的用户参考使用 peacewong@WDS 12:16 华金兄 建议这里提个PR优化下，不做强转，改为直接获取String.valueOf。应该就没有兼容性的问题了。 peacewong@WDS 12:17 结果应该是一样的，没有强转的必要性 casion 12:21 我看修改记录，好像是特意修的bug加的强转 peacewong@WDS 12:23 感觉要优化下，没必要。 peacewong@WDS 12:24 这里抛出异常也没必要： --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@linkis.apache.org For additional commands, e-mail: dev-h...@linkis.apache.org
