————— 2022-5-30 ————— Heisenberg 19:23 Brother Ping ask a question, for the core method of the engine executeLine(engineExecutorContext: EngineExecutionContext, code: String)
Is it possible to simplify the construction of an engineExecutorContext to implement the test case? Is the core function of the test engine normal? Heisenberg 19:23 @peacewong @WDS peacewong@WDS 19:56 Yes, Brother Longping Heisenberg 19:57 [breaks tears into laughter] Is there an example? peacewong@WDS 19:59 Just create one according to create Heisenberg 20:00 Mmm Good Heisenberg 20:02 There are quite a lot of revisions in this PR. I switched dbcp to dbcp2, and reserved the access entry for multiple data source switching. It is a major reconstruction based on the original JDBC engine. Suggestions peacewong@WDS 20:20 OK, no problem. Is it changed to a unified druid. Now the linkis are all cut into druid Heisenberg 20:25 [Breaking tears and laughing] I feel that Druid is more suitable if the underlying database is used for services. After all, the monitoring is more comprehensive. If it is an engine computing service, dbcp2 is relatively lightweight, not bad in efficiency, and relatively simple to configure. Heisenberg 20:25 I don't know how compatible druid is with hive jdbc, I haven't tested it before [cover face] peacewong@WDS 20:27 Just the connection pool should not be a problem, right? peacewong@WDS 20:28 I feel that doing two will confuse developers. Heisenberg 20:28 Ok, let me see how to change it peacewong@WDS 20:29 The difference is not big, brother Long Ping, you can refer to linkis-mybatis Heisenberg 20:30 OK ————— 2022-5-30 ————— 海森堡 19:23 平哥 请教一个问题，针对引擎的核心方法executeLine(engineExecutorContext: EngineExecutionContext, code: String) 是否可以简化构造一个engineExecutorContext 来实现测试用例 测试引擎的核心功能是否正常 海森堡 19:23 @peacewong@WDS peacewong@WDS 19:56 可以的，龙平兄 海森堡 19:57 [破涕为笑]有例子嘛 peacewong@WDS 19:59 就按照create创建一个就好的 海森堡 20:00 嗯嗯好的 海森堡 20:02 平哥 这个PR 修改还挺多的，切换dbcp到dbcp2，并预留了多数据源切换的接入入口，算是在原有JDBC引擎基础上进行了较大的重构，有空帮忙review下，提提建议 peacewong@WDS 20:20 好的，没问题的。是不是改成统一的druid。现在linkis都切成druid了 海森堡 20:25 [破涕为笑]感觉如果是服务底层用数据库的话，druid比较合适，毕竟监控比较全面嘛， 如果是引擎计算服务的话，dbcp2较为轻量，效率也不差，配置的话也比较简单 海森堡 20:25 不知道druid 对 hive jdbc之类的兼容性如何，之前也没有测试过 [捂脸] peacewong@WDS 20:27 只是连接池应该问题不大吧？ peacewong@WDS 20:28 感觉搞两个会让开发者混淆的 海森堡 20:28 好的 我看看 怎么换下 peacewong@WDS 20:29 区别不大的，龙平兄，可以参考下linkis-mybatis 海森堡 20:30 好的 --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@linkis.apache.org For additional commands, e-mail: dev-h...@linkis.apache.org
