————— 2022-6-5 ————— Mr. Lightning 19:26 1.2.0
peacewong@WDS 19:27 Okay, let's discuss it together Heisenberg 19:27 Mmmmm, 1.2.0 peacewong@WDS 21:51 Brother Long Ping, I think it needs to be standardized, and data source information cannot be defined casually. Heisenberg 21:59 JDBC engine database connection parameters, the parameters are currently unified Heisenberg 21:59 Image 1 (can be viewed in the attachment) Heisenberg 21:59 name Heisenberg 22:01 Otherwise, just use it uniformly, wds.linkis.jdbc. The specific meaning and name, and then add the document where the document is needed, and if you want to add additional parameters later, also indicate in the document Heisenberg 22:03 At the same time, the data source is newly added, the relational database is here, the parameter template of JDBC is unified, and there is no need to divide the specific relational database, such as: mysql, oracle, psql, etc. Heisenberg 22:03 Image 2 (can be viewed in the attachment) peacewong@WDS 22:33 But we need to consider the compatibility with the old ones, and see if it is compatible with a mapping between parameters. Heisenberg 22:34 Data source connection parameters, or connection parameters in the engine? peacewong@WDS 22:34 The data source is here, if modified according to the specification Heisenberg 22:35 Is there a data source already in use? peacewong@WDS 22:36 Yes, so if you really modify it here, you need to consider compatibility. For example, qualitis is in use. Heisenberg 22:36 If yes, it would be better to maintain the mapping, because the engine needs to be fixed here Heisenberg 22:37 I will add an intermediate layer, a converter, to convert the data source connection parameters into the format required by the engine. peacewong@WDS 22:37 OK Heisenberg 22:39 OK ————— 2022-6-5 ————— 闪电先生 19:26 1.2.0 peacewong@WDS 19:27 好的，大家一起讨论下 海森堡 19:27 嗯嗯，1.2.0 peacewong@WDS 21:51 龙平兄，我觉得也需要规范下的，不能随便定义数据源信息 海森堡 21:59 JDBC引擎 数据库连接参数，目前把参数统一了的 海森堡 21:59 图片1（可在附件中查看） 海森堡 21:59 命名 海森堡 22:01 要不然 就这样统一用，wds.linkis.jdbc.具体含义名称，然后需要文档的地方，就加文档，后续如果要增加额外参数的话，也在文档中注明 海森堡 22:03 同时数据源新增，关系型数据库这里，统一JDBC的参数模版，不用分具体的关系型数据库，如：mysql、oracle、psql等 海森堡 22:03 图片2（可在附件中查看） peacewong@WDS 22:33 但是要考虑下兼容老的，看是不是做个参数间映射兼容下 海森堡 22:34 数据源连接参数， 还是引擎哪里的连接参数？ peacewong@WDS 22:34 数据源这里的，如果按照规范修改后 海森堡 22:35 现在有地方已经用到数据源了吧 peacewong@WDS 22:36 对的，所以这里如果真修改需要考虑兼容，比如qualitis就有在用的 海森堡 22:36 如果是的，那维护映射会好一点，因为引擎这里 其实需求固定 海森堡 22:37 我这边加一个中间层，转换器，用来把数据源连接参数，转换成引擎这里需要的格式 peacewong@WDS 22:37 可以的 海森堡 22:39 好的 --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@linkis.apache.org For additional commands, e-mail: dev-h...@linkis.apache.org
