————— 2022-6-14 ————— Quintin.Tao 14:54 Big man. I added a test case to jdbc's engine JDBCEngineConnExecutor. Using the H2 database, it seems that several parts of the source code need to be changed slightly.
Quintin.Tao 14:54 The first is that you need to add a judgment to the ConnectionManager Quintin.Tao 14:55 Because H2's jdbc connection is not compliant. Heisenberg 14:55 1.2.0 has tweaked this peacewong@WDS 14:55 @CCweixiao_intsig_leojie Brother Longping, the maintainer of the jdbc engine, please check it out Heisenberg 14:55 do you have anything else Quintin.Tao 14:55 There are also constants that need to be added to H2 here Heisenberg 14:56 You can see that these places have changed in 1.2.0 Heisenberg 14:56 Compatible with h2 also cancels support dbs Quintin.Tao 14:57 oh oh. That's it. Then I will pull the code to see peacewong@WDS 15:12 The latest development branch is 1.2.0, Tao Shixiong can submit your single test to this branch @Quintin.Tao Quintin. Tao 15:13 Uh-huh. OK learn ————— 2022-6-14 ————— Quintin.Tao 14:54 大佬啊。我给jdbc 的engine JDBCEngineConnExecutor 加了一个测试用例。使用H2数据库，貌似源代码的几个地方需要稍微改改才可以。 Quintin.Tao 14:54 首先是ConnectionManager里需要加一下判断 Quintin.Tao 14:55 因为H2 的jdbc连接不太合规。 海森堡 14:55 1.2.0有调整这个 peacewong@WDS 14:55 @CCweixiao_intsig_leojie 龙平兄 jdbc引擎的维护者，帮忙check下 海森堡 14:55 还有别的吗 Quintin.Tao 14:55 还有这里需要加H2 的常量 海森堡 14:56 可以看1.2.0的 这些地方都有改动 海森堡 14:56 兼容h2 也取消了support dbs Quintin.Tao 14:57 哦哦。这样啊。那我拉一下代码看看 peacewong@WDS 15:12 最新的开发分支是1.2.0，陶时兄可以提交你的单测到这个分支下@Quintin.Tao Quintin.Tao 15:13 嗯嗯。好的。了解 --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@linkis.apache.org For additional commands, e-mail: dev-h...@linkis.apache.org
