————— 2022-6-14 ————— peacewong@WDS 20:03 @CCweixiao_intsig_leojie @weizhong-xiachen The two big guys help to review this PR, increase the unit test coverage display, compile steps with specific commands, and modify the group QR code picture https://github.com/apache/incubator- linkis/pull/2280
Heisenberg 20:05 receive Casion 20:22 Regarding the use of compilation, see if you need to explain the situation under win cmd peacewong@WDS 20:23 I don't see any special instructions for windows in other projects. It's not too long to make up one. I'll add it. peacewong@WDS 20:27 added Casion 20:50 https://github.com/apache/incubator-linkis-website/issues/339 In the official website document, remove the QQ community QR code and use the mvnw command to compile and package the project. This adjustment also creates a new task, which is relatively easy to adjust. Interested students are welcome to claim it peacewong@WDS 21:00 @liangqilang_boss Zhipin_Zhu Hui Big Brother The two small places where the file supports mobile PR need to be optimized. It has been commented https://github.com/apache/incubator-linkis/pull/2277#pullrequestreview-1005817346 Amphibian 21:00 ok Heisenberg 21:36 @Quintin.Tao Boss, I see some methods in the test case. The connection is your own mysql environment. It is estimated that an error will be reported when this GitHub action is compiled. Could you please confirm? Quintin. Tao 21:38 The connection is to start the H2 service Quintin.Tao 21:39 Are you referring to this part of the information? Quintin.Tao 21:40 The actual effect should be the following part. Quintin. Tao 21:41 In order to understand this part of the parameters, I kept the above part Quintin.Tao 21:42 How about this. I changed it to H2 to avoid inconvenience caused by negligence. Heisenberg 21:42 Hmm, I read it wrong, you have already checked Heisenberg 21:42 no problem no problem Quintin.Tao 21:44 OK big guy case 22:19 Can this one in the packaging module be removed? The version before linkis 1.0 is that each microservice has a separate conf directory @peacewong@WDS @leebai@WDS peacewong@WDS 22:20 Yes, it can be removed. Mr. Lightning 22:22 The packaged result of the plugin is out.zip, which is a little inconvenient in actual use. Would it be better to change it to the same name as the plugin? e.g. flink.zip peacewong@WDS 22:25 Yes, it can be optimized, it should be unnecessary to look at zip now. The zip of many services should not be used, which can speed up the compilation speed Casion 22:30 At present, the linkis-client module has a separate configuration, and it should be adjusted to the conf directory. There should be no problem. peacewong@WDS 22:42 no problem. ————— 2022-6-14 ————— peacewong@WDS 20:03 @CCweixiao_intsig_leojie @微众-夏晨 两位大佬帮忙review下这个PR，增加单元测试覆盖率展示、编译步骤加上具体命令、修改群二维码图片https://github.com/apache/incubator-linkis/pull/2280 海森堡 20:05 收到 casion 20:22 关于编译的使用 看需不需要说明下 win cmd下的情况 peacewong@WDS 20:23 我看其他项目都没有特殊说明windows，补一个也可以反正也不长，我加下。 peacewong@WDS 20:27 加上了 casion 20:50 https://github.com/apache/incubator-linkis-website/issues/339 官网文档中 移除QQ社群二维码以及项目编译打包文档统一使用mvnw命令。这个调整也新建了一个任务， 比较容易调整，欢迎感兴趣的同学认领 peacewong@WDS 21:00 @liangqilang_boss直聘_朱辉 大佬 文件支持移动PR两个小的地方需要优化下，已经评论了https://github.com/apache/incubator-linkis/pull/2277#pullrequestreview-1005817346 两栖狼 21:00 ok 海森堡 21:36 @Quintin.Tao 大佬我看测试用例中的一些方法，连接的是你自己的mysql环境，这个GitHub action编译的时候估计会报错，麻烦确认下？ Quintin.Tao 21:38 连的是启动的H2服务 Quintin.Tao 21:39 您指这部分信息吗？ Quintin.Tao 21:40 实际生效的应该是下面这部分。 Quintin.Tao 21:41 我为了理解这部分参数，才留着上面这部分的 Quintin.Tao 21:42 这样吧。我都改成H2 避免有疏忽带来不便。 海森堡 21:42 嗯嗯 我看错了，你check都过了 海森堡 21:42 没问题没问题的 Quintin.Tao 21:44 好的。大佬 casion 22:19 打包模块中的这个是不是可以移除掉了， linkis1.0之前的版本才是每个微服务有单独的conf目录吧 @peacewong@WDS @leebai@WDS peacewong@WDS 22:20 是的，可以移除了。 闪电先生 22:22 插件那个打包的结果，每一个都是out.zip，实际使用的时候，有些不方便，是不是改成和插件一样的名字会好一些? 例如flink.zip peacewong@WDS 22:25 是的，可以优化下，现在看zip应该是没必要的。很多服务的zip应该都没用到，可以加快些编译速度 casion 22:30 目前linkis-client模块有单独配置，统一调整到conf目录下 应该也没有什么问题吧 peacewong@WDS 22:42 没什么问题。 --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@linkis.apache.org For additional commands, e-mail: dev-h...@linkis.apache.org
