Hi folks,

I just noticed that AgaviContext::initialize() doesn't necessarily  
have to be public... it would actually better to have it as private,  
as instance creation is, and should be, handled solely by  
AgaviContext::getInstance().

Either way, it also seems odd that initialize() needs the "profile"  
name (= context name). That should be done in the constructor, as  
otherwise, you need to do
$ctx->initialize($ctx->getName());
instead of
$ctx->initialize();
to "restart" a context (which I don't think really works anyway... re- 
initing a context doesn't really reset the entire system.

We want to have a proper restart() or reinit() method on the context  
and the associated factories for 1.1.

Until then... I'm considering fixing this inconsistency for 1.0, so my  
question is:

is anyone using AgaviContext::initialize() in their code?

Thanks for your replies,

David



_______________________________________________
Agavi Dev Mailing List
[email protected]
http://lists.agavi.org/mailman/listinfo/dev

Reply via email to