Hi everybody,
I'm currently splitting things from the application class into different
class but I'm trying to not break anything ;)
I've noticed that the behaviour of the get_url() method is quite random :
From the code and the doc it uses the current url as a base and
add/overrides query string parameters with the ones from the arguments.
In its usage (in breadcrumbs mainly) it only uses the script name but do
not keep all the current parameters from the query string.
Obviously, if I'm on the page :
run.php?application=forum&go=viewer&display_action=forum_viewer&publication_id=1
I want the Forum link on the breadcrumb to link to :
http://localhost/chamilo-dev/run.php?application=forum
and therefore, I need to forget current query string.
I think it currently works because the get_url is called before the
parameters array is populated but this is very dangerous (and not the
case anymore in my refactoring). So which one of the behaviour should we
keep :
-> keep query string (very useful for all links except breadcrumb)
-> forget query string (and pass current query string as a parameter to
get_url when it is needed)
Those 2 options will break stuff but I'd like to have your opinion
Systho
_______________________________________________
Dev mailing list
Dev@lists.chamilo.org
http://lists.chamilo.org/listinfo/dev
