Re: [chamilo-dev] C2M chamilo: [Systho] added TWIG to plugins

Thu, 05 May 2011 07:02:37 -0700 

Hi Philippe,
While I realize you're very enthusiastic about this I would really advise you to go ahead slowly (well slower anyway) with this. We still have a very long way to go untill the entire FrontController-thingamabob gets implemented in Chamilo 2. 


It's no real problem that you added it, but you can actually just add 
the plugin to your package just the same. There's no real reason you 
shouldn't be able to do this. (the autoloader part might be a bit 
tricky, but not that tricky I would guess ... might be something as 
simple as adding a registration method to the existing autoloaders). 
It's not because the packages don't have plugin folders by default that 
they can't have them ;-) Several external repository managers already 
have them to keep those very specific plugins from polluting the global 
folder.


Best regards,
Hans

On 05/05/2011 15:45, Philippe Van Eerdenbrugghe wrote:

Hi Hans (& everybody)


This is part of the FrontController / Request / Response / etc 
refactoring.



Unofrtunately, I can't share the work I've already done without 
breaking at least some stuff, even if I did my best to design the code 
I wrote to not break anything.



Therefore I will rework the whole stuff (withtout compromise) so that 
it will really be a big improvement but it will also need a rework of 
all the optional apps.
I'm currently using our optional app (which I can break ) as a sandbox 
but I need a template engine to do that.



Since it there is no support (currently) for an app having its own 
thirdparty plugins I put it on the global space and I'm working on 
classes to abstract it out which I write in my optional app and which 
I'll move to core once release has been done


Systho

Le 5/05/2011 15:18, Hans De Bisschop a écrit :

Hi Philippe,


Could you please provide a bit of information about the why/how/what 
of the inclusion of TWIG in the global plugin folder?


Thanks in advance,
Hans

On 05/05/2011 15:14, Chamilo 2 AT Bitbucket wrote:

Repository: chamilo-dev
Revision: 2128
Node: 111fe0291cb4
Link:https://bitbucket.org/chamilo/chamilo-dev/changeset/111fe0291cb4

Author: Systho
Date: 2011-05-05 15:12:39
Pushed by: Systho

Log Message:
------------
  added TWIG to plugins and modified register_autoload() to take it into account

Added Paths:
------------
common/libraries/plugin/Twig/Autoloader.php
common/libraries/plugin/Twig/Compiler.php
common/libraries/plugin/Twig/CompilerInterface.php
common/libraries/plugin/Twig/Environment.php
common/libraries/plugin/Twig/Error.php
common/libraries/plugin/Twig/Error/Loader.php
common/libraries/plugin/Twig/Error/Runtime.php
common/libraries/plugin/Twig/Error/Syntax.php
common/libraries/plugin/Twig/ExpressionParser.php
common/libraries/plugin/Twig/Extension.php
common/libraries/plugin/Twig/Extension/Core.php
common/libraries/plugin/Twig/Extension/Escaper.php
common/libraries/plugin/Twig/Extension/Optimizer.php
common/libraries/plugin/Twig/Extension/Sandbox.php
common/libraries/plugin/Twig/ExtensionInterface.php
common/libraries/plugin/Twig/Filter.php
common/libraries/plugin/Twig/Filter/Function.php
common/libraries/plugin/Twig/Filter/Method.php
common/libraries/plugin/Twig/FilterInterface.php
common/libraries/plugin/Twig/Function.php
common/libraries/plugin/Twig/Function/Function.php
common/libraries/plugin/Twig/Function/Method.php
common/libraries/plugin/Twig/FunctionInterface.php
common/libraries/plugin/Twig/Lexer.php
common/libraries/plugin/Twig/LexerInterface.php
common/libraries/plugin/Twig/Loader/Array.php
common/libraries/plugin/Twig/Loader/Filesystem.php
common/libraries/plugin/Twig/Loader/String.php
common/libraries/plugin/Twig/LoaderInterface.php
common/libraries/plugin/Twig/Markup.php
common/libraries/plugin/Twig/Node.php
common/libraries/plugin/Twig/Node/AutoEscape.php
common/libraries/plugin/Twig/Node/Block.php
common/libraries/plugin/Twig/Node/BlockReference.php
common/libraries/plugin/Twig/Node/Expression.php
common/libraries/plugin/Twig/Node/Expression/Array.php
common/libraries/plugin/Twig/Node/Expression/AssignName.php
common/libraries/plugin/Twig/Node/Expression/Binary.php
common/libraries/plugin/Twig/Node/Expression/Binary/Add.php
common/libraries/plugin/Twig/Node/Expression/Binary/And.php
common/libraries/plugin/Twig/Node/Expression/Binary/Concat.php
common/libraries/plugin/Twig/Node/Expression/Binary/Div.php
common/libraries/plugin/Twig/Node/Expression/Binary/Equal.php
common/libraries/plugin/Twig/Node/Expression/Binary/FloorDiv.php
common/libraries/plugin/Twig/Node/Expression/Binary/Greater.php
common/libraries/plugin/Twig/Node/Expression/Binary/GreaterEqual.php
common/libraries/plugin/Twig/Node/Expression/Binary/In.php
common/libraries/plugin/Twig/Node/Expression/Binary/Less.php
common/libraries/plugin/Twig/Node/Expression/Binary/LessEqual.php
common/libraries/plugin/Twig/Node/Expression/Binary/Mod.php
common/libraries/plugin/Twig/Node/Expression/Binary/Mul.php
common/libraries/plugin/Twig/Node/Expression/Binary/NotEqual.php
common/libraries/plugin/Twig/Node/Expression/Binary/NotIn.php
common/libraries/plugin/Twig/Node/Expression/Binary/Or.php
common/libraries/plugin/Twig/Node/Expression/Binary/Power.php
common/libraries/plugin/Twig/Node/Expression/Binary/Range.php
common/libraries/plugin/Twig/Node/Expression/Binary/Sub.php
common/libraries/plugin/Twig/Node/Expression/BlockReference.php
common/libraries/plugin/Twig/Node/Expression/Conditional.php
common/libraries/plugin/Twig/Node/Expression/Constant.php
common/libraries/plugin/Twig/Node/Expression/ExtensionReference.php
common/libraries/plugin/Twig/Node/Expression/Filter.php
common/libraries/plugin/Twig/Node/Expression/Function.php
common/libraries/plugin/Twig/Node/Expression/GetAttr.php
common/libraries/plugin/Twig/Node/Expression/Name.php
common/libraries/plugin/Twig/Node/Expression/Parent.php
common/libraries/plugin/Twig/Node/Expression/Test.php
common/libraries/plugin/Twig/Node/Expression/Unary.php
common/libraries/plugin/Twig/Node/Expression/Unary/Neg.php
common/libraries/plugin/Twig/Node/Expression/Unary/Not.php
common/libraries/plugin/Twig/Node/Expression/Unary/Pos.php
common/libraries/plugin/Twig/Node/For.php
common/libraries/plugin/Twig/Node/If.php
common/libraries/plugin/Twig/Node/Import.php
common/libraries/plugin/Twig/Node/Include.php
common/libraries/plugin/Twig/Node/Macro.php
common/libraries/plugin/Twig/Node/Module.php
common/libraries/plugin/Twig/Node/Print.php
common/libraries/plugin/Twig/Node/Sandbox.php
common/libraries/plugin/Twig/Node/SandboxedModule.php
common/libraries/plugin/Twig/Node/SandboxedPrint.php
common/libraries/plugin/Twig/Node/Set.php
common/libraries/plugin/Twig/Node/Spaceless.php
common/libraries/plugin/Twig/Node/Text.php
common/libraries/plugin/Twig/NodeInterface.php
common/libraries/plugin/Twig/NodeOutputInterface.php
common/libraries/plugin/Twig/NodeTraverser.php
common/libraries/plugin/Twig/NodeVisitor/Escaper.php
common/libraries/plugin/Twig/NodeVisitor/Optimizer.php
common/libraries/plugin/Twig/NodeVisitor/SafeAnalysis.php
common/libraries/plugin/Twig/NodeVisitor/Sandbox.php
common/libraries/plugin/Twig/NodeVisitorInterface.php
common/libraries/plugin/Twig/Parser.php
common/libraries/plugin/Twig/ParserInterface.php
common/libraries/plugin/Twig/Sandbox/SecurityError.php
common/libraries/plugin/Twig/Sandbox/SecurityPolicy.php
common/libraries/plugin/Twig/Sandbox/SecurityPolicyInterface.php
common/libraries/plugin/Twig/Template.php
common/libraries/plugin/Twig/TemplateInterface.php
common/libraries/plugin/Twig/Test/Function.php
common/libraries/plugin/Twig/Test/Method.php
common/libraries/plugin/Twig/TestInterface.php
common/libraries/plugin/Twig/Token.php
common/libraries/plugin/Twig/TokenParser.php
common/libraries/plugin/Twig/TokenParser/AutoEscape.php
common/libraries/plugin/Twig/TokenParser/Block.php
common/libraries/plugin/Twig/TokenParser/Extends.php
common/libraries/plugin/Twig/TokenParser/Filter.php
common/libraries/plugin/Twig/TokenParser/For.php
common/libraries/plugin/Twig/TokenParser/From.php
common/libraries/plugin/Twig/TokenParser/If.php
common/libraries/plugin/Twig/TokenParser/Import.php
common/libraries/plugin/Twig/TokenParser/Include.php
common/libraries/plugin/Twig/TokenParser/Macro.php
common/libraries/plugin/Twig/TokenParser/Sandbox.php
common/libraries/plugin/Twig/TokenParser/Set.php
common/libraries/plugin/Twig/TokenParser/Spaceless.php
common/libraries/plugin/Twig/TokenParser/Use.php
common/libraries/plugin/Twig/TokenParserBroker.php
common/libraries/plugin/Twig/TokenParserBrokerInterface.php
common/libraries/plugin/Twig/TokenParserInterface.php
common/libraries/plugin/Twig/TokenStream.php

Modified Paths:
---------------
common/libraries/php/utilities.class.php 
(https://bitbucket.org/chamilo/chamilo-dev/diff/common/libraries/php/utilities.class.php?diff2=111fe0291cb4&diff1=783b4ae054a0)




--

*Hans De Bisschop*
Hoofddeskundige ICTO | Lead Developer Chamilo 2.0
Software Coordinator Chamilo Association
Erasmushogeschool Brussel
Nijverheidskaai 170 | B-1070 Brussel
T 02 559 02 54 | i 254

hans.de.bissc...@ehb.be <mailto:hans.de.bissc...@ehb.be> | 
www.erasmushogeschool.be <http://www.erasmushogeschool.be/>



Kom eens langs: www.erasmushogeschool.be/infodagen 
<http://www.erasmushogeschool.be/infodagen>
of lees onze elektronische nieuwsbrief: ehbrief.ehb.be 
<http://ehbrief.ehb.be/>

P Before printing, think about the environment


_______________________________________________
Dev mailing list
Dev@lists.chamilo.org
http://lists.chamilo.org/listinfo/dev



_______________________________________________
Dev mailing list
Dev@lists.chamilo.org
http://lists.chamilo.org/listinfo/dev

--

*Hans De Bisschop*
Hoofddeskundige ICTO | Lead Developer Chamilo 2.0
Software Coordinator Chamilo Association
Erasmushogeschool Brussel
Nijverheidskaai 170 | B-1070 Brussel
T 02 559 02 54 | i 254

hans.de.bissc...@ehb.be <mailto:hans.de.bissc...@ehb.be> | 
www.erasmushogeschool.be <http://www.erasmushogeschool.be/>



Kom eens langs: www.erasmushogeschool.be/infodagen 
<http://www.erasmushogeschool.be/infodagen>
of lees onze elektronische nieuwsbrief: ehbrief.ehb.be 
<http://ehbrief.ehb.be/>

P Before printing, think about the environment


_______________________________________________
Dev mailing list
Dev@lists.chamilo.org
http://lists.chamilo.org/listinfo/dev






















					Reply via email to