Just making sure this ends up on the dev list ;-)
-------- Original Message --------
Subject: Re: [chamilo-dev] C2M chamilo-app-weblcms: [Nathalie] Feature
#3162 access to courses for non-
Date: Fri, 10 Jun 2011 16:27:28 +0200
From: Nathalie Blocry <nblo...@vub.ac.be>
To: Hans De Bisschop <hans.de.bissc...@ehb.be>
There is no need for a database change. however in the xml the type is
set as "boolean" but the data sent to stored there are 0's an 1's. This
is not a problem for any of us for the moment as the field created is a
tiny int in mysql and we are all using mysql. I remember Peter Bex
saying that is a problem on other databases that do expect true and
false instead of 1 and 0.
The field can and should stay a tinyint, like it already was. in the xml
file you cannot define a tiny int. I changed it back to boolean, but
this is not really correct.
about the "feature". it is not a new feature it is an adaptation of the
already existing feature where you had 2 choices, now you have 4.
I have already mentioned many times we need this functionality and I was
waiting for the new right system to be stable so I could see if it would
affect anything before being able to push this functionality
Op 06/10/2011 04:16 PM, Hans De Bisschop schreef:
Hi all,
I'm afraid I have to agree with Stefaan. No new features or
storage-changes on the stable repositories please. Feel free to "have
fun" on the dev repositories though :-P Hopefully this commit was
accidently pushed to the stable repository?
Best regards,
Hans De Bisschop
Erasmushogeschool Brussel
On 10/06/2011 15:38, Stefaan Vanbillemont wrote:
Nathalie,
I thought we agreed some time ago that new feature implementations
should go into the DEV repos in not in the stable repos !!!!!
We need to rely on the stable repositories for our production system
(within 3 weeks) so new database changes are a NO GO .. We made some
clear agreements on this months ago and announced it enough on the
dev lists afterwards!
Can you please commit this new feature to the dev repos and revert
this commit?
Kind Regards,
Stefaan Vanbillemont
Hogeschool Gent
Op 10/06/11 15:34, Chamilo 2 AT Bitbucket schreef:
Repository: chamilo-app-weblcms
Revision: 661
Node: e8b91e42646e
Link:
https://bitbucket.org/chamilo/chamilo-app-weblcms/changeset/e8b91e42646e
Author: Nathalie
Date: 2011-06-10 15:34:11
Pushed by: NathalieB
Log Message:
------------
Feature #3162 access to courses for non-subscribed and anonymous users
Modified Paths:
---------------
php/blocks/type/course_catalog.class.php
(https://bitbucket.org/chamilo/chamilo-app-weblcms/diff/php/blocks/type/course_catalog.class.php?diff2=e8b91e42646e&diff1=70d818902b1b)
php/install/course_settings.xml
(https://bitbucket.org/chamilo/chamilo-app-weblcms/diff/php/install/course_settings.xml?diff2=e8b91e42646e&diff1=70d818902b1b)
php/lib/course/common_form.class.php
(https://bitbucket.org/chamilo/chamilo-app-weblcms/diff/php/lib/course/common_form.class.php?diff2=e8b91e42646e&diff1=70d818902b1b)
php/lib/course/course.class.php
(https://bitbucket.org/chamilo/chamilo-app-weblcms/diff/php/lib/course/course.class.php?diff2=e8b91e42646e&diff1=70d818902b1b)
php/lib/course/course_form.class.php
(https://bitbucket.org/chamilo/chamilo-app-weblcms/diff/php/lib/course/course_form.class.php?diff2=e8b91e42646e&diff1=70d818902b1b)
php/lib/course/course_list_renderer/open_course_type_course_list_renderer.class.php
(https://bitbucket.org/chamilo/chamilo-app-weblcms/diff/php/lib/course/course_list_renderer/open_course_type_course_list_renderer.class.php?diff2=e8b91e42646e&diff1=70d818902b1b)
php/lib/course/course_settings.class.php
(https://bitbucket.org/chamilo/chamilo-app-weblcms/diff/php/lib/course/course_settings.class.php?diff2=e8b91e42646e&diff1=70d818902b1b)
php/lib/weblcms_manager/component/course_viewer.class.php
(https://bitbucket.org/chamilo/chamilo-app-weblcms/diff/php/lib/weblcms_manager/component/course_viewer.class.php?diff2=e8b91e42646e&diff1=70d818902b1b)
_______________________________________________
Dev mailing list
Dev@lists.chamilo.org
http://lists.chamilo.org/listinfo/dev
--
*Hans De Bisschop*
Adviseur | Lead Developer Chamilo 2.0
Software Coordinator Chamilo Association
Erasmushogeschool Brussel
Nijverheidskaai 170 | B-1070 Brussel
T 02 559 02 54 | i 254
hans.de.bissc...@ehb.be <mailto:hans.de.bissc...@ehb.be> |
www.erasmushogeschool.be <http://www.erasmushogeschool.be/>
Kom eens langs: www.erasmushogeschool.be/infodagen
<http://www.erasmushogeschool.be/infodagen>
of lees onze elektronische nieuwsbrief: ehbrief.ehb.be
<http://ehbrief.ehb.be/>
P Before printing, think about the environment
_______________________________________________
Dev mailing list
Dev@lists.chamilo.org
http://lists.chamilo.org/listinfo/dev
--
*Hans De Bisschop*
Adviseur | Lead Developer Chamilo 2.0
Software Coordinator Chamilo Association
Erasmushogeschool Brussel
Nijverheidskaai 170 | B-1070 Brussel
T 02 559 02 54 | i 254
hans.de.bissc...@ehb.be <mailto:hans.de.bissc...@ehb.be> |
www.erasmushogeschool.be <http://www.erasmushogeschool.be/>
Kom eens langs: www.erasmushogeschool.be/infodagen
<http://www.erasmushogeschool.be/infodagen>
of lees onze elektronische nieuwsbrief: ehbrief.ehb.be
<http://ehbrief.ehb.be/>
P Before printing, think about the environment
_______________________________________________
Dev mailing list
Dev@lists.chamilo.org
http://lists.chamilo.org/listinfo/dev
