Hi, > > Attached are some revised patched. They add the modifierhandler.cpp > > and modifierhandler.h files. > > > > Danny suggested that the modHandler object did not belong in the > > PrivateScreen class (and have a getter in CompScreen). I evaluated the > > code and do not think this makes sense because modHandler depends the > > CompScreen *screen variable to be initialized and also uses some of > > it's internal methods.
While it's debatable whether putting the ModifierHandler instance inside or outside the screen class makes more sense (you already mentioned my personal opinion on that matter), your two arguments for putting it inside the class are no problem at all: - Instantiating ModifierHandler after CompScreen makes sure the order of initialization is correct. - Surely ModifierHandler calls some CompScreen methods, but so does any plugin around there. CompScreen is the central object of compiz++, after all. Regards, Danny _______________________________________________ Dev mailing list [email protected] http://lists.compiz-fusion.org/mailman/listinfo/dev
