On Sat, Feb 7, 2009 at 1:45 PM, Danny Baumann <[email protected]> wrote: > Hi, > > I have some comments regarding some new commits and cherry-picks to the > 0.8 branch. > >> commit 2d00dd0d241768e2b4bce3ef448411804a760ed5 >> Author: Erkin Bahceci <[email protected]> >> Date: Mon Apr 7 11:02:12 2008 -0500 >> >> Avoid conflict with Animation by suppressing fading. >> >> commit ce6cf1fb06525fe76b0bdba08e1548070f7b88b4 >> Author: Kristian Lyngstol <[email protected]> >> Date: Sat Feb 7 01:30:09 2009 +0100 >> >> Add ABI-saftey net and bump ABI >> >> The void *reserved; variables will allow us to add a single real pointer >> during 0.8 without breaking the ABI. > > I don't think we want those two in the master branch: > - The animation fade conflict IMO should only be present in stable > branches because while it improves the user experience for new users, > it's not a "correct" solution, so it shouldn't be on master. > - I am not sure why we'd need an "ABI safety net" on master. I > definitely see a reason to have it in the stable branch, but on master I > see no problems in ABI bumps.
Master is going to be compiz++ in a very short time. I agree that both these patches belong in a stable branch, but do we really need to revoke them on master, when that's essentially discontinued? >> commit 1734e848e5e262d2a965f4a15c4067b0fd791bde >> Author: Jigish Gohil <[email protected]> >> Date: Wed Nov 26 16:32:07 2008 +0530 >> >> remove zoom from POTFILES.in too >> > >> commit e789f81a44309336131ffbe914dcc1e9619a63cc >> Author: Kristian Lyngstol <[email protected]> >> Date: Sun Nov 23 14:56:31 2008 +0100 >> >> Remove zoom plugin, this is replaced by Enhanced Zoom in Compiz Fusion > > I thought we wanted to keep the zoom plugin in 0.8 because of various > regressions ezoom has compared to zoom (e.g. missing manual panning). > Did I miss anything? No, I've not finished yet. I got a little lazy, so instead of cherry picking 95% of the commits, I merged and am about to remove the 5% that we don't want. Sorry about the confusion. Speaking of zoom, my plan is basically to revoke the commits that remove it. There shouldn't be any problems with that, as far as I am aware? - Kristian _______________________________________________ Dev mailing list [email protected] http://lists.compiz-fusion.org/mailman/listinfo/dev
