It's been several hours, so it's time to nag Guillaume again!

Could we get some better commit mails?

One easy (hopefully) change is to change the reply-to to be
[email protected] (I just noticed my alias still said compiz-fusion for
the last mail).

Ideally I'd like one mail per commit so I can review and comment on each
individually - that's also how git is designed. Ie, how git format-patch
would output it. Here's a sample from ezoom, prefixed with quotes:

> From ed928087172b5a94f90868c94b266d062b1d40ad Mon Sep 17 00:00:00 2001
> From: Kristian Lyngstol <[email protected]>
> Date: Sun, 26 Sep 2010 05:00:42 +0200
> Subject: [PATCH] Minor nitpicks, part one
> 
> I am going through the code looking for stupid stuff I can fix, but ergh...
> ---
>  src/ezoom.cpp |   17 +++++++++--------
>  src/ezoom.h   |   42 +++++-------------------------------------
>  2 files changed, 14 insertions(+), 45 deletions(-)
> 
> diff --git a/src/ezoom.cpp b/src/ezoom.cpp
> index c32a677..15eccfc 100644
> --- a/src/ezoom.cpp
> +++ b/src/ezoom.cpp
> @@ -67,7 +67,6 @@
>   *
>   * Todo:

(...)

Should be easy to understand why this is nicer to deal with - specially
with regards to the subject.

Getting a sensible from-address on the mails would also be nice (not
[email protected]), though I suppose that might not be trivial
and that a simple updated alias would be close enough (dare I suggest
"[email protected]" ?).

- Kristian

Attachment: signature.asc
Description: Digital signature

_______________________________________________
dev mailing list
[email protected]
http://lists.compiz.org/mailman/listinfo/dev

Reply via email to