[compiz-dev] [PATCH] Compile emerald with -Werror=format-security

[Julien]

Hi,

Not sure if emerald is still developed but anyway, here is a patch to
compile the compiz++ branch with -Werror=format-security.

regards
Julien
Index: src/engine_loader.c
===================================================================
--- src/engine_loader.c
+++ src/engine_loader.c	2012-02-07 16:59:27.970840216 +0100
@@ -54,7 +54,7 @@
         newengine = dlopen(path,RTLD_NOW);
         if (!newengine)
         {
-            g_warning(dlerror());
+            g_warning("%s", dlerror());
             //here's where we should bail out somehow
         }
     }
Index: libengine/themer.c
===================================================================
--- libengine/themer.c
+++ libengine/themer.c	2012-02-07 16:58:33.518378085 +0100
@@ -874,7 +874,7 @@
     err = dlerror();
     if (!hand || err)
     {
-        g_warning(err);
+        g_warning("%s", err);
         if (hand)
             dlclose(hand);
         return;
@@ -885,7 +885,7 @@
         layout_settings_proc lay;
         lay = dlsym(hand,"layout_engine_settings");
         if ((err=dlerror()))
-            g_warning(err);
+            g_warning("%s", err);
         if (lay)
         {
             get_meta_info_proc meta;
@@ -896,7 +896,7 @@
                 "<i><small>%s</small></i>";
             meta = dlsym(hand,"get_meta_info");
             if ((err=dlerror()))
-                g_warning(err);
+                g_warning("%s", err);
                 d->meta.description=g_strdup("No Description");
                 d->meta.version=g_strdup("0.0");
                 d->meta.last_compat=g_strdup("0.0");
Index: themer/main.c
===================================================================
--- themer/main.c
+++ themer/main.c	2012-02-09 16:07:46.830328766 +0100
@@ -264,6 +264,7 @@
             GTK_DIALOG_DESTROY_WITH_PARENT,
             GTK_MESSAGE_INFO,
             GTK_BUTTONS_CLOSE,
+            "%s",
             val);
     gtk_dialog_run(GTK_DIALOG(w));
     gtk_widget_destroy(w);
@@ -275,6 +276,7 @@
             GTK_DIALOG_DESTROY_WITH_PARENT,
             GTK_MESSAGE_ERROR,
             GTK_BUTTONS_CLOSE,
+            "%s",
             val);
     gtk_dialog_run(GTK_DIALOG(w));
     gtk_widget_destroy(w);

_______________________________________________
dev mailing list
dev@lists.compiz.org
http://lists.compiz.org/mailman/listinfo/dev