Hi Ajay,
Thanks for providing your comments and feedback. We have started working
on the unit tests. I agree that we should have a good test coverage
before it is merged.
We will submit the patch for review in gerrit to have a code review and
address the review/design comments and also incorporate the changes done
by you to improve the performance.
I guess we can have a blue print to track this activity.
Thanks
Numan
On 04/22/2015 11:32 PM, Hampapur Ajay wrote:
Hi Numan,
The refactor was needed and welcome.The overall approach is good but
before merging it would be good to do following activities since
change is pretty large.
1. unit tests to exercise the code-paths as best we can (main reason
for re-factor)
2. functional/system tests to find impact on performance +
functionality. tempest + sys test scripts will test most of
functionality. For performance we are in process of publishing scripts
to test scale that I can point to. As Ashish mentioned we have
significantly improved performance in mainline and I am assuming you
are incorporating changes in mainline neutron_plugin_db.py into the
refactoring periodically. Ideally we need to run the performance
script on same system with/without refactor to ensure it is equivalent
or better.
some comments I had are:
at
https://github.com/Juniper/contrail-controller/compare/master...cloudwatt:vnc_openstack_refactor#diff-d58d35a13da5ae202c2f947c9fa97af3R132
there is an assumption that resource doesn't have '_' in its
type-name, while currently true for things in schema, we don't want to
limit ourselves to that.
at
https://github.com/Juniper/contrail-controller/compare/master...cloudwatt:vnc_openstack_refactor#diff-d58d35a13da5ae202c2f947c9fa97af3R155
it should be 'project_read' instead of 'virtual_project_read' right?
will look through
https://github.com/Juniper/contrail-controller/compare/master...cloudwatt:vnc_openstack_refactor#diff-40da8c2bfebffe0f9e7f36dd4b4de359R735
in more detail later since this is most critical op (port list) for
performance.
thanks
ajay
On Apr 15, 2015, at 10:31 AM, Ashish Ranjan wrote:
hi Numan,
Ajay has been working to improve performance for many of these
APIs. He is out this week. I will check with him to review this early
next week.
We should be able to join forces on this effort.
regards,
Ashish
On Apr 13, 2015, at 12:42 AM, Numan Siddique
<[email protected] <mailto:[email protected]>>
wrote:
Hello dev team,
We (Cloudwatt) are working on refactoring the vnc_openstack code.
The reason we are doing this activity is because
- to optimize some code - particularly related to listing of
resources (net-list, port-list etc) as presently it is taking lot of
time
and this can be optimized.
- presently there are not much unit tests. By refactoring and
reorganizing the code, we can add unit tests to cover various
scenarios and data paths.
- to make the code more organized so that maintaining could be easier.
The code is here [1] and it is work in progress. We wanted to know
the community's opinion/thoughts/comments/criticism on this
activity. So please let us know the same.
[1] -
https://github.com/cloudwatt/contrail-controller/tree/vnc_openstack_refactor/src/config/vnc_openstack/vnc_openstack
Thanks
Numan
_______________________________________________
Dev mailing list
[email protected] <mailto:[email protected]>
http://lists.opencontrail.org/mailman/listinfo/dev_lists.opencontrail.org
_______________________________________________
Dev mailing list
[email protected]
http://lists.opencontrail.org/mailman/listinfo/dev_lists.opencontrail.org
