That's Great :) Regards, Yatin
On Mon, Jun 1, 2015 at 9:33 PM, Harshad Nakil <[email protected]> wrote: > Sylvain, > > I agree with you in principle. However as of today, all bugs cannot be put > in open source as they may have sensitive customer information. Either we > may have to have bug tracking tool that allows to make certain portions of > the bugs private OR we open public bug for every bug we may to keep > private. Till we figure out that, it is still beneficial to track every > commit with bug, public or private. > > Regards > -Harshad > > On Jun 1, 2015, at 6:50 AM, Sylvain Afchain <[email protected]> wrote: > > > Hi All, > > > > Could we add something to be sure that the bug is marked as "public" ? > Because some patches have bug link to private bug. > > > > Thanks, > > > > Sylvain > > > > ----- Original Message ----- > > From: "Numan Siddique" <[email protected]> > > To: [email protected] > > Sent: Monday, June 1, 2015 10:27:47 AM > > Subject: Re: [opencontrail-dev] lp bug number mandatory in commit message > > > > Hi Vinay, > > Does it mean that we need to raise a bug even for blueprint patches ? > > > > Thanks > > Numan > > > > On 05/29/2015 10:04 PM, Vinay Vithal Mahuli wrote: > > > > > > > > Hi, > > > > We have enabled changes for making launchpad bug number mandatory in the > commit message when a user submits review. > > > > The Code-Review field in the review will be marked as –2, if there is no > bug number in the commit message. > > To reset Code review field (follow instructions below), the user needs > to submit a new patch-set with the bug number in commit message. > > > > #git commit —amend > > > > #edit commit message by adding bug number, generally in one of below > mentioned format: > > > > > > 1. Closes-Bug: #1234567 > > 2. Partial-Bug: #1234567 > > 3. Related-Bug: #1234567 > > 4. Bug: #1234567 > > > > #git review > > > > This is implemented to help bug tracking. > > > > Regards, > > Vinay > > > > > > _______________________________________________ > > Dev mailing list [email protected] > http://lists.opencontrail.org/mailman/listinfo/dev_lists.opencontrail.org > > > > > > _______________________________________________ > > Dev mailing list > > [email protected] > > > http://lists.opencontrail.org/mailman/listinfo/dev_lists.opencontrail.org > > > > _______________________________________________ > > Dev mailing list > > [email protected] > > > http://lists.opencontrail.org/mailman/listinfo/dev_lists.opencontrail.org > > > _______________________________________________ > Dev mailing list > [email protected] > http://lists.opencontrail.org/mailman/listinfo/dev_lists.opencontrail.org >
_______________________________________________ Dev mailing list [email protected] http://lists.opencontrail.org/mailman/listinfo/dev_lists.opencontrail.org
