Sylvain, I posted a comment for 6161 identifying a potential issue. Please take a look.
Perhaps you can separate the test framework from discovery server code change so that test harness can go in ASAP and we can start adding other cases to it? Thanks Deepinder. From: Ashish Ranjan Date: Wednesday, July 8, 2015 at 12:06 PM To: Sylvain Afchain Cc: "[email protected]<mailto:[email protected]>", Deepinder SETIA, Prakash M Bailkeri, Hampapur Ajay, Rudra Rugge, Divakar Dharanalakota Subject: Re: [opencontrail-dev] Call for reviews Prakash, Rudra could you own 9991. Divakar & Deepinder pl own 12100 and 6131 respectively. thanks Ashish On Jul 8, 2015, at 1:53 AM, Sylvain Afchain <[email protected]<mailto:[email protected]>> wrote: Hi Opencontrail Devs, I have few patches that are in gerrit since a while now, if someone could have a look, it would be nice. One[1] is to move remaining SNAT code from the vnc_openstack to the service_monitor, since the code to handle external interface has already been moved, this patch moves the internal interfaces handling as well. The other one[2] is to re-add to the vrouter agent introspec the stderr output when a netns script fails. I think this feature has been removed during a refactoring job. For the last one[3] which fixes the round-robin algorithm in the discovery and introduces UTs, I need some help since the patch is failing in jenkins and I'm not able to understand/reproduce the issue on my side. Thanks, Sylvain [1] https://review.opencontrail.org/#/c/9991/ [2] https://review.opencontrail.org/#/c/12100/ [3] https://review.opencontrail.org/#/c/6131/ _______________________________________________ Dev mailing list [email protected]<mailto:[email protected]> http://lists.opencontrail.org/mailman/listinfo/dev_lists.opencontrail.org
_______________________________________________ Dev mailing list [email protected] http://lists.opencontrail.org/mailman/listinfo/dev_lists.opencontrail.org
