Note also that the change (38631) is “only” a test. It doesn’t modify any functionality at all, it simply adds a test to catch a regression of the bug. The bug itself was fixed in https://review.opencontrail.org/#/c/37346 which has already been merged in the 3.2 branch. Specifically, 37346 is a backport to the 3.2 branch. I don’t know the number of the original commit that was backported or whether that commit had a corresponding unit test, but the backport to 3.2 was done without adding a unit test to the 3.2 branch. Appreciation to Deepak for noticing this and providing the unit test.
This speaks to a TSC/ARB topic on general principle. Some projects (and methodologies, e.g. TDD) have a firm rule that when you fix a bug you should also add a test that fails pre-fix and passes post-fix in order to catch regressions if the bug is ever re-introduced. Currently Contrail development does not follow this practice strictly. Many bug fix commits are merged without including a corresponding test to detect the bug and confirm that the fix works. Moving to a strict policy probably can’t be done all at once, but this is the kind of discussion the TSC should have and set policy on. In some of the OpenStack projects I’ve worked on, lack of adequate tests is valid reason for giving a -1/-2 on a code review that fixes a bug or introduces a new feature. The theory being, that if you allow code to be merged and trust that tests will be added later, there’s a significant chance that your trust may be vindicated. -- Paul Carver VoIP: 732-545-7377 Cell: 908-803-1656 E: pcar...@att.com<mailto:pcar...@att.com> Q Instant Message<qto://talk/pc2929> It is difficult to make predictions. Especially about the future. From: Dev [mailto:dev-boun...@lists.opencontrail.org] On Behalf Of Gregory Elkinbard Sent: Thursday, January 04, 2018 16:51 To: Sukhdev Kapur <sukh...@juniper.net>; Deepak Tiwari <deepak.tiw...@aricent.com>; dev@lists.opencontrail.org Subject: Re: [opencontrail-dev] Commit to R3.2 branch It is logged as a bug. https://review.opencontrail.org/#/c/38631/<https://urldefense.proofpoint.com/v2/url?u=https-3A__review.opencontrail.org_-23_c_38631_&d=DwMGaQ&c=LFYZ-o9_HUMeMTSQicvjIg&r=xtmPik_TP2fjPVGWP4yBRQ&m=Y2u6lzm-FYeTt8kgi1G65XOjErYImy7sNcUx56YGfAU&s=j2N93xp3CCbFVfw7WPUB7qc1XrA9Ueo5jn4COIj3VnU&e=> Greg From: Sukhdev Kapur <sukh...@juniper.net<mailto:sukh...@juniper.net>> Date: Thursday, January 4, 2018 at 1:49 PM To: Deepak Tiwari <deepak.tiw...@aricent.com<mailto:deepak.tiw...@aricent.com>>, Gregory Elkinbard <gelkinb...@juniper.net<mailto:gelkinb...@juniper.net>>, "dev@lists.opencontrail.org<mailto:dev@lists.opencontrail.org>" <dev@lists.opencontrail.org<mailto:dev@lists.opencontrail.org>> Subject: Re: [opencontrail-dev] Commit to R3.2 branch Was it a bug fix? If yes, please log the bug as well. Thanks -Sukhdev From: Deepak Tiwari <deepak.tiw...@aricent.com<mailto:deepak.tiw...@aricent.com>> Date: Thursday, January 4, 2018 at 9:51 AM To: Gregory Elkinbard <gelkinb...@juniper.net<mailto:gelkinb...@juniper.net>>, "dev@lists.opencontrail.org<mailto:dev@lists.opencontrail.org>" <dev@lists.opencontrail.org<mailto:dev@lists.opencontrail.org>> Cc: Sukhdev Kapur <sukh...@juniper.net<mailto:sukh...@juniper.net>> Subject: RE: [opencontrail-dev] Commit to R3.2 branch Hi Gregory, Thanks for the reply. It was not any critical change. I have committed it to master for now Br, Deepak From: Gregory Elkinbard [mailto:gelkinb...@juniper.net] Sent: 04 January 2018 01:08 To: Deepak Tiwari <deepak.tiw...@aricent.com<mailto:deepak.tiw...@aricent.com>>; dev@lists.opencontrail.org<mailto:dev@lists.opencontrail.org> Cc: Sukhdev Kapur <sukh...@juniper.net<mailto:sukh...@juniper.net>> Subject: Re: [opencontrail-dev] Commit to R3.2 branch In general, community contributions are open from release 5.0 onwards (current master). However if you are working with Contrail engineering on a specific bug for maintenance branch, you can get permission to commit to maintenance branches Is there somebody in eng that you are working with on addressing this bug? Greg From: Dev <dev-boun...@lists.opencontrail.org<mailto:dev-boun...@lists.opencontrail.org>> on behalf of Deepak Tiwari <deepak.tiw...@aricent.com<mailto:deepak.tiw...@aricent.com>> Date: Wednesday, January 3, 2018 at 8:10 AM To: "dev@lists.opencontrail.org<mailto:dev@lists.opencontrail.org>" <dev@lists.opencontrail.org<mailto:dev@lists.opencontrail.org>> Subject: [opencontrail-dev] Commit to R3.2 branch Hi, Just wanted to know if commits on R3.2 branch are prohibited on Gerrit? I tried pushing some changes to Gerrit for R3.2 branch (contrail-vrouter) but it failed. It gave merging error message, but it can’t be merging error as I was adding new files. Thereafter I pushed same changes on master branch which went ok. So all I could guess was that maybe commits to R3.2 branches are prohibited in general (barring critical fixes)? Br, Deepak "DISCLAIMER: This message is proprietary to Aricent and is intended solely for the use of the individual to whom it is addressed. It may contain privileged or confidential information and should not be circulated or used for any purpose other than for what it is intended. If you have received this message in error, please notify the originator immediately. If you are not the intended recipient, you are notified that you are strictly prohibited from using, copying, altering, or disclosing the contents of this message. Aricent accepts no responsibility for loss or damage arising from the use of the information transmitted by this email including damage from virus." "DISCLAIMER: This message is proprietary to Aricent and is intended solely for the use of the individual to whom it is addressed. It may contain privileged or confidential information and should not be circulated or used for any purpose other than for what it is intended. If you have received this message in error, please notify the originator immediately. If you are not the intended recipient, you are notified that you are strictly prohibited from using, copying, altering, or disclosing the contents of this message. Aricent accepts no responsibility for loss or damage arising from the use of the information transmitted by this email including damage from virus."
_______________________________________________ Dev mailing list Dev@lists.opencontrail.org http://lists.opencontrail.org/mailman/listinfo/dev_lists.opencontrail.org
