Yeah, neat! You know of course when you provide a visualization like this, people will want to expand the options :) For instance it would be nice to see the duration starting from applying the "lgtm" label (in repos where that applies), or from the first approval response, or from the first [merge] comment (in repos where that applies), or from the first commit, or time of opening the PR... and be able to change the buckets accordingly since those will imply different distributions. And how many PRs were closed without merging, and whether their owners closed them or someone else...
Needs a "reset options" button too. You know, just a few things :) On Thu, Aug 31, 2017 at 9:04 AM, Michail Kargakis <[email protected]> wrote: > Hi Martin, > > this is cool! Do you compare the time when a PR opened with the time > it merged? Also are you using directly the github API or anothre > library? Gtihub API v3 or v4? > > In Origin we have deployed a new CI system, which has been running for > some time in Kubernetes, that merges PRs based on a set of labels. It > would be nice to see Origin graphs from the past two months by taking > into account the time the "lgtm" label was added in a PR (I would be > surprised if we can't get that info from Github) and not the creation > of the PR, assuming that's what you are doing. > > https://raw.githubusercontent.com/ocasek/GithubGraphs/ > master/Screenshot_2.png > It's nice to see how the number of PRs older than 2 days has decreased > in the past two months :) > > On Thu, Aug 31, 2017 at 2:39 PM, Martin Nečas <[email protected]> > wrote: > > Hello, > > > > My name is Martin Nečas and I'm high school student and Red Hat intern in > > Brno. > > http://martin.codingkwoon.com/ > > This is my project in which you can compare how long does it take to > merge > > pull requests per months.If you put there new repository, it will need be > > confirmed by admin of the site for security reasons. > > I would be glad if you could give me some feed back about the project. > > > > Screenshot: http://imgur.com/a/JyoAv > > Source code: https://github.com/ocasek/GithubGraphs > > Examples: > > 1) http://martin.codingkwoon.com/openshift/origin/ > > 2) http://martin.codingkwoon.com/kubernetes/kubernetes/ > > 3) http://martin.codingkwoon.com/openshift/openshift-ansible/ > > > > > > With greetings, > > Martin Nečas > > > > _______________________________________________ > > dev mailing list > > [email protected] > > http://lists.openshift.redhat.com/openshiftmm/listinfo/dev > > > > _______________________________________________ > dev mailing list > [email protected] > http://lists.openshift.redhat.com/openshiftmm/listinfo/dev >
_______________________________________________ dev mailing list [email protected] http://lists.openshift.redhat.com/openshiftmm/listinfo/dev
