(Cross posting to the original mail thread)
-------- Forwarded Message --------
Subject: [e2e] [aos-devel] Simple pre-flight checks for 'oc adm diag',
feedback needed
Date: Mon, 30 Oct 2017 09:59:59 +0100
From: Bogdan Dobrelya <[email protected]>
Organization: Red Hat
To: e2e <[email protected]>, aos-devel <[email protected]>,
[email protected]
Could I please ask for a code review and feedback for a new
openshift-ansible pre-flight connectivity check [0]?
Note that it implements an empty place-holder for the connectivity check
(and tag) to follow the standard interface for auto-detecting and
listing all the available checks and tags by the ansible provider.
While the check itself is "externally" managed and is nothing more that
just an ansible playbook. I placed TODOs there, but I'm not sure that I
want to invoke the ansible playbook from the python script, this would
look confusing and not native IMO. I look forward for better ideas and
feedback. Thanks!
[0] https://github.com/openshift/openshift-ansible/pull/5883
--
Best regards,
Bogdan Dobrelya,
Irc #bogdando
_______________________________________________
dev mailing list
[email protected]
http://lists.openshift.redhat.com/openshiftmm/listinfo/dev
