On Thu, Jun 21, 2018 at 4:21 PM, Ben Parees <bpar...@redhat.com> wrote:
> > > On Thu, Jun 21, 2018 at 6:36 AM, Charles Moulliard <cmoul...@redhat.com> > wrote: > >> Hi Charles, >> >> The info shared is really valuable as it describes a new BuildStrategy >> type (= Custom) that the BuildController will process. >> >> To be honest, I was looking about a general document describing the S2i >> Spec v1 Architecture, API, use cases supported and the entities (described >> as field, type, size, default value,...) >> > > from an openshift perspective, that would be the buildconfig api spec: > > https://docs.openshift.org/latest/rest_api/apis-build. > openshift.io/v1.BuildConfig.html#object-schema > > you can drill down into the "sourcestrategy" field. > > > >> Such info should help us to discuss current situation and improvements to >> propose for S2I Spec v2 such as decouple compilation from docker build, ... >> > > we've recently implemented the ability for s2i to output a dockerfile > (which can then be built w/ non-docker technologies like Kaniko or Buildah) > in the upstream source-to-image project. We'll be looking to bring it to > openshift in the near future. > >> Is it this PR which supports this option -> https://github.com/openshift/source-to-image/pull/878 ? That means that the dockerfile created could be then processed by non docker tools such buildah, kanibo, ... ? > > You can get a good overall sense of the "api" of s2i by looking at the s2i > config struct: > > https://github.com/openshift/source-to-image/blob/master/ > pkg/api/types.go#L50 > > > > and adopt a new version of the BuildConfig >> >> e.g >> >> spec: >> output: >> to: >> kind: ImageStreamTag >> name: 'spring-boot-rest-http:1.5.13-1' >> baseImage: openjdk1.8:1.3.7 >> source: >> git: >> type: Git >> Strategy: >> compilation: >> tool: maven >> version: 3.5 >> command: mvn test && mvn package -Dxxx >> sourceStrategy: >> from: >> kind: ImageStreamTag >> name: 's2i-imageORplaybook:latest' >> >> Regards >> >> Charles >> >> >> >> On Thu, Jun 21, 2018 at 11:57 AM, Charles Sabourdin < >> kanedafrompa...@gmail.com> wrote: >> >>> Hi Charles, >>> >>> is that : >>> - https://docs.openshift.com/container-platform/3.9/creatin >>> g_images/custom.html#creating-images-custom >>> - https://github.com/YannMoisan/openshift-tagger-custom-builder >>> - https://github.com/openshift/origin/blob/master/images/bu >>> ilder/docker/docker-builder/Dockerfile >>> >>> The kind of infos you are looking for ? >>> >>> because It seems to me that s2i is pretty much a "specific type of custom >>> build". >>> >>> >>> Le jeu. 21 juin 2018 à 11:45, Tako Schotanus <tscho...@redhat.com> a >>> écrit : >>> >>>> Aren't the links at the end of the README basically what you're looking >>>> for? >>>> >>>> On Thu, Jun 21, 2018 at 11:37 AM Charles Moulliard <cmoul...@redhat.com> >>>> wrote: >>>> >>>>> This project "source-to-image" represents the top part of the iceberg >>>>> to build a s2i image but not how it is processed ate the server side by >>>>> the >>>>> BuildConfigController >>>>> >>>>> >>>>> >>>>> On Thu, Jun 21, 2018 at 11:24 AM, Tako Schotanus <tscho...@redhat.com> >>>>> wrote: >>>>> >>>>>> THis is probably a good place to start Charles: https://github.com/op >>>>>> enshift/source-to-image >>>>>> >>>>>> On Thu, Jun 21, 2018 at 10:24 AM Charles Moulliard < >>>>>> cmoul...@redhat.com> wrote: >>>>>> >>>>>>> Hi, >>>>>>> >>>>>>> Excepted the API and Controller [1], I haven't been able to find >>>>>>> another source of information. So my queation is : Is there a >>>>>>> document presenting and explaining the S2I spec ? >>>>>>> >>>>>>> Is it possible to discuss/collaborate with Origin team in order to >>>>>>> propose enhancements ? How ? >>>>>>> >>>>>>> [1] https://github.com/openshift/origin/blob/master/pkg/buil >>>>>>> d/apis/build/v1/defaults.go >>>>>>> [2] Build Type : https://github.com/openshift >>>>>>> /api/blob/master/build/v1/types.go, Controller: https://github.com >>>>>>> /openshift/origin/blob/master/pkg/build/controller/buildconf >>>>>>> ig/buildconfig_controller.go >>>>>>> >>>>>>> Regards >>>>>>> >>>>>>> Charles >>>>>>> _______________________________________________ >>>>>>> dev mailing list >>>>>>> dev@lists.openshift.redhat.com >>>>>>> http://lists.openshift.redhat.com/openshiftmm/listinfo/dev >>>>>>> >>>>>> >>>>>> >>>>>> -- >>>>>> >>>>>> TAKO SCHOTANUS >>>>>> >>>>>> SENIOR SOFTWARE ENGINEER >>>>>> >>>>>> Red Hat >>>>>> >>>>>> <https://www.redhat.com/> >>>>>> <https://red.ht/sig> >>>>>> >>>>>> >>>>> >>>> >>>> -- >>>> >>>> TAKO SCHOTANUS >>>> >>>> SENIOR SOFTWARE ENGINEER >>>> >>>> Red Hat >>>> >>>> <https://www.redhat.com/> >>>> <https://red.ht/sig> >>>> >>>> _______________________________________________ >>>> dev mailing list >>>> dev@lists.openshift.redhat.com >>>> http://lists.openshift.redhat.com/openshiftmm/listinfo/dev >>>> >>> >> >> _______________________________________________ >> dev mailing list >> dev@lists.openshift.redhat.com >> http://lists.openshift.redhat.com/openshiftmm/listinfo/dev >> >> > > > -- > Ben Parees | OpenShift > >
_______________________________________________ dev mailing list dev@lists.openshift.redhat.com http://lists.openshift.redhat.com/openshiftmm/listinfo/dev
