there are a few problems with this one - most significantly, you did not update the pkgver or the pkgrel - the repo would not accept that package because it has the identical filename as the existing one - at the very least, the pkgrel needs to be bumped - but it is not obvious what pkgver represents - we probably discussed this before but i forgot - was this intended to be the date of the VCS commit? - if so, the pkgver should have changed instead - so im not sure how to proceed
i tried to get that date myself; but when i went to the upstream VCS website, i could not find _upstream_rev=5922 anywhere - where does that number come from? - how would i known which date _upstream_rev=5922 was committed? https://hg.prosody.im/prosody-modules/shortlog/tip maybe the source should use the IDs shown on that website instead, such as today's tip 'f408b8e603af' - would that work? _upstream_rev=f408b8e603af mksource=(${pkgname}-${pkgver}::hg+https://hg.prosody.im/prosody-modules/#revision=${_upstream_rev}) one less important thing, i reverted this change: -# Copyright (C) 2022 Wael Karram <[email protected]> +# Copyright (C) 2024 Wael Karram <[email protected]> im still on the fence about those copyright lines - the reason we started putting 'SPDX-License-Identifier: CC0' is because really, no one believes that these recipes are copyrightable - on that presumption, the only significant change that you made to this file in 2024 is not copyrightable by any measure -_upstream_rev=5579 +_upstream_rev=5922 if any of that PKGBUILD is copyrightable, it would be the initial complete version - most likely, this package will never receive any copyrightable changes after the initial publishing - so i think in these cases, the original year when the PKGBUILD was written can remain, unless some truly significant change is made - that will never happen for most PKGBUILDs also, the year in the copyright line is supposed to identify all years in which significant changes were made - so if this year's changes were significant, then so would be the changes in 2023 - in that case the copyright line would be 2022-2024 _______________________________________________ Dev mailing list [email protected] https://lists.parabola.nu/mailman/listinfo/dev
