On Thu, 2 Oct 2025 09:47:32 -0400
bill-auger <[email protected]> wrote:

> this one has some housekeeping issues:
> 
> * no Maintainer specified - must be a LOC beginning: '# Maintainer:' 
> * arch=(x86_64) - missing armv7h and i686
> * makedepends=(git) - 'git' is unused/unneeded
> * lots of unused code - the 'prepare()' and '_check()' functions, for
> example, are not used
> * the conflicts=() are not necessary - those are all AUR packages -
>   no packages in the parabola repos would match these conflicts
> _______________________________________________
> Dev mailing list
> [email protected]
> https://lists.parabola.nu/mailman/listinfo/dev

Hello,
I've attached a patch with the required clean-up.

-- 
Kind Regards,
Wael Karram.
From ced2f529176c61c828600b1547f3ca63250d183b Mon Sep 17 00:00:00 2001
From: wael <[email protected]>
Date: Mon, 6 Oct 2025 15:06:14 +0300
Subject: [PATCH] Packaged game of trees version control system.

---
 pcr/got/PKGBUILD | 37 ++++---------------------------------
 1 file changed, 4 insertions(+), 33 deletions(-)

diff --git a/pcr/got/PKGBUILD b/pcr/got/PKGBUILD
index 6b2921d16..5f169d7ed 100644
--- a/pcr/got/PKGBUILD
+++ b/pcr/got/PKGBUILD
@@ -1,34 +1,18 @@
-# Maintainer (AUR): Adrian Perez de Castro <[email protected]>
-# Maintainer (Parabola): Wael Karram <[email protected]>
+# Contributor: Adrian Perez de Castro <[email protected]>
+# Maintainer: Wael Karram <[email protected]>
 
 pkgname=gameoftrees
 pkgver=0.119
 pkgrel=1
 pkgdesc='A version control system which prioritizes ease of use and simplicity over flexibility'
-arch=(x86_64)
+arch=(x86_64 i686 armv7h)
 url="https://gameoftrees.org";
 license=(ISC)
-conflicts=(gameoftrees-git got got-git got-bin)
 depends=(ncurses util-linux-libs libbsd libevent zlib libretls libmd util-linux-libs)
-# lib32-util-linux)
-makedepends=(git pkgconf bison)
-#source=("$url/releases/portable/got-portable-$pkgver.tar.gz")
+makedepends=(pkgconf bison)
 source=("https://codeberg.org/stsp/got-portable/archive/$pkgver.tar.gz";)
 sha256sums=('c4f8053a9df9acbb2c3390e537d74abd4f2c38d6f3e3674d484f6bf88d58bb52')
 
-prepare () {
-	#
-	# Test suites expect /bin/sh to be OpenBSD ksh, which is available
-	# as the "oksh" package. Change the shebang in testing scripts.
-	#
-	return
-	cd "got-portable"
-	sed -i -e '1s/\/sh$/\/oksh/' \
-		regress/cmdline/*.sh \
-		regress/gotd/*.sh \
-		regress/tog/*.sh
-}
-
 build () {
 	cd got-portable
 	./autogen.sh
@@ -38,19 +22,6 @@ build () {
 	make
 }
 
-# TODO: Investigate why many tests still fail
-_check () {
-	#
-	# We need a different build that can be installed to a local prefix
-	# directory, because the test suite will pick binaries from $PATH.
-	#
-	cd "got-portable-$pkgver"
-	local prefix="$(pwd)/_prefix"
-	./configure --prefix="$prefix"
-	make install
-	#PATH="$prefix/bin:$PATH" make tests
-}
-
 package () {
 	make -Cgot-portable DESTDIR="$pkgdir" install
 	cd got-portable
-- 
2.51.0

Attachment: pgpzz7Qk4G9nt.pgp
Description: OpenPGP digital signature

_______________________________________________
Dev mailing list
[email protected]
https://lists.parabola.nu/mailman/listinfo/dev

Reply via email to