If I modify your patch to be hard coded metaKey like below (just for testing on
my Mac) then command-click works correctly for me in Firefox and Safari, not
IE. I couldn't get IE to work using either metaKey or keyCode == 91.
So I think you can use the metaKey for command, but I read online somewhere
that on Windows it corresponds to the Windows key so you definitely may want
some functioning platform detection for it. Maybe a preference? Although that
may just be confusing pref bloat.
: jamie
--------
I'm completely in favor of the separation of Church and State. My idea is that
these two institutions screw us up enough on their own, so both of them
together is certain death.
- George Carlin
Index: app.js
===================================================================
RCS file: /cvsroot/roundcubemail/roundcubemail/program/js/app.js,v
retrieving revision 1.32
diff -r1.32 app.js
268d267
< if (e.stopPropagation) e.stopPropagation();
296c295
< } else {return false};
---
> } else {return true;}
2967a2967,2972
> var keyControl = e.ctrlKey;
>
> //if (this.mac) {
> keyControl = e.metaKey;
> //}
>
2970c2975
< opcode += (e.ctrlKey && CONTROL_KEY) + (e.shiftKey && SHIFT_KEY);
---
> opcode += (keyControl && CONTROL_KEY) + (e.shiftKey && SHIFT_KEY);
On Fri, 03 Mar 2006 13:11:38 -0600, Charles McNulty <[EMAIL PROTECTED]> wrote:
> Removing the context menu is definitely an unrelated change in app.js.
> Thanks for testing it for me. If nothing different is happening at all,
> I suspect that it's because the javascript code that recognizes the
> platform isn't working properly. There's not much more I can offer than
> what I already have without having a Mac to test on.
>
> -Charles
>
> Jamie Halmick wrote:
>> I tried applying these changes and the command key still doesn't do
> anything. If I use ctrl-click I get the desired behavior but no
> context-menu (maybe that's just a change in the newer app.js I downloaded
> from cvs) except if I hold ctrl-shift-click the context menu flashes up
> for a second and disappears. I'll make sure I've updated the entire app
> from cvs later tonight and re-apply the patch and test.
>>
>> : jamie
>>
>> --------
>> By doing just a little each day, I can gradually let the task overwhelm
> me.
>>
>>
>> On Fri, 03 Mar 2006 08:54:02 -0600, Charles McNulty
> <[EMAIL PROTECTED]> wrote:
>>> Can someone with a Mac test this patch and see if it works for IE
> and/or
>>> Mozilla, Safari, etc? Again what is being tested it the use of the
>>> Command key for selecting single non-continuous messages.
>>>
>>> -Charles
>>>
>>>
>>>
>>> Charles McNulty wrote:
>>>> Actually, looking at the code again, it might not be that hard to
>>>> support IE for Mac. Can any Mac users confirm on this page:
>>>> http://www.quirksmode.org/js/events/keys.html
>>>> that the keyCode for Command is 91?
>>>>
>>>> -Charles
>>>>
>>>> Jamie Halmick wrote:
>>>>> The standard behavior is for
>>>>>
>>>>> command-click to perform non-contiguous multiple select.
>>>>> shift-click performs contiguous multiple select
>>>>> command-shift-click appears to perform just like shift-click
>>>>>
>>>>> At least that's how it works in the Finder, which I think should be
>>>>> the Mac
>>>>> reference for this type of behaviour.
>>>>>
>>>>> I think that substituting command for control with the current
>>> roundcube
>>>>> behaviour would be fine though as it's really just "more"
>>> functionality.
>>>>> : jamie
>>>>>
>>>>> --------
>>>>> "Much human ingenuity has gone into finding the ultimate Before. The
>>>>> current
>>>>> state of knowledge can be summarized thus: In the beginning, there
> was
>>>>> nothing,
>>>>> which exploded"
>>>>> - Terry Pratchett
>>>>>
>>>>>
>>>>> On Thu, 02 Mar 2006 16:21:20 -0600, Charles McNulty
>>>>> <[EMAIL PROTECTED]> wrote:
>>>>>> Is that the standard behavior for Macs? When I implemented the
>>>>>> select/control-click behavior, I studied exactly what Outlook,
> Outlook
>>>>>> Express and Thunderbird did in Windows (XP) and attempted to emulate
>>>>>> that exact behavior. I don't have a Mac, but if someone could
>>> describe
>>>>>> the exact behavior and key combinations with a Mac on a similar set
> of
>>>>>> standard applications, I'd be happy to attempt to implement it.
>>>>>>
>>>>>> Key combinations to test are:
>>>>>>
>>>>>> Click
>>>>>> Shift-Click
>>>>>> Command-Click
>>>>>> Command-Shift-Click
>>>>>>
>>>>>> Situations to test are each of these in different combinations with
>>> each
>>>>>> other in different scenarios:
>>>>>>
>>>>>> When nothing is selected
>>>>>> When a continous list of things are selected
>>>>>> When a non-continuous list of things are selected
>>>>>>
>>>>>> So for instance, what happens when you click a list item,
> shift-click
>>> an
>>>>>> item 5 below it, command-click an item two up from that one and then
>>>>>> command-shift-click an item another 10 up from that?
>>>>>>
>>>>>> If you can tell me definitively that a Command-click and
>>>>>> command-shift-click do the exact same thing in all situations as a
>>>>>> Control, then that will be an easy change. The key is
> predictability.
>>>>>> What I'm going for here is the exact same behavior in RC as in ...
>>> well
>>>>>> whatever you Mac users use for e-mail.
>>>>>>
>>>>>> -Charles
>>>>>>
>>>>>> Jamie Halmick wrote:
>>>>>>> This new select behavior is nice for contiguous selection but
> doesn't
>>>>>> really work on Macintosh. When you control-click you get the context
>>>>>> menu
>>>>>> (right click for Mac). Can you add the behavior so that the Command
>>> key
>>>>>> will do the same on the Mac as Control?
>>>>>>> : jamie
>>>>>>>
>>>>>>> --------
>>>>>>> "I love deadlines. I like the whooshing sound they make as they fly
>>> by"
>>>>>>> - Douglas Adams
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>
>>>>>
>>>>
>>>
>>
>>
>>
