On Fri, 9 Jun 2006 08:04:22 -0700, [EMAIL PROTECTED] wrote:
> On Jun 9, 2006, at 5:04 AM, Martin Marques wrote:
> 
>>
>> People I have a BUG with a patch that I want to submit and I can't  
>> get the ticket in the trac system. Even worst, I had a real hard  
>> time finding the link to add a new ticket. Help wasn't to  
>> helpfull. :-(
>>
>> Can someone give me a flow from after I logged in to the part where  
>> I have to add the report? Else I'll just send the patch to Thomas  
>> or this list.
> 
> Could you post it to the list so we can see it? :)

OK, below it the problem and the patch.

Now, I kept looking at trac to see how to add the new ticket, and I found 
(after logging in) http://trac.roundcube.net/trac.cgi/newticket which gave me 
this error:

Permission Denied

TICKET_CREATE privileges are required to perform this operation

OK, I get it, but why can't I create a new ticket? Or am I totally mistaken and 
this is not the way to report a bug with trac?

By the way, my username is mmarques

To the BUG:

I've been seeing lots of errors in the log/errors file related to DELETE 
commands to the DB (PostgreSQL in my case):

[09-Jun-2006 08:27:23 -0300] DB Error: DB Error: unknown error Query: DELETE 
FROM messages WHERE  user_id='1' AND    cache_key='pgsql-ayuda.msg' AND    
idx>=FALSE [nativecode=ERROR:  el operador no existe: integer >= boolean HINT:  
Ning?n operador coincide con el nombre y el tipo de los argumentos. Puede 
desear agregar conversiones expl?citas de tipos.] in 
/var/www/html/roundcubemail/program/include/rcube_db.inc on line 478

Tracking down the error I found out that in the DELETE execution, sometimes the 
last argument wasn't passed right, and I found out that it was related to the 
clear_message_cache method in rcube_imap.

Here's the patch:


$ svn diff program/include/rcube_imap.inc
Index: program/include/rcube_imap.inc
===================================================================
--- program/include/rcube_imap.inc      (revision 259)
+++ program/include/rcube_imap.inc      (working copy)
@@ -1052,8 +1052,8 @@
       $start_index = 100000;
       foreach ($a_uids as $uid)
         {
-        $index = array_search($uid, $a_cache_index);
-        $start_index = min($index, $start_index);
+       if(($index = array_search($uid, $a_cache_index)) !== FALSE)
+         $start_index = min($index, $start_index);
         }
 
       // clear cache from the lowest index on


P.D.: Is it posible to add a reply-to the list?

-- 
---------------------------------------------------------
Lic. Martín Marqués         |   SELECT 'mmarques' || 
Centro de Telemática        |       '@' || 'unl.edu.ar';
Universidad Nacional        |   DBA, Programador, 
    del Litoral             |   Administrador
---------------------------------------------------------




Reply via email to