Yes, while I was testing I found the unread count was not included in the other count. I understand what you mean about only trying to loop through the recent items.
I was also unable to fix one thing. When adding new recent items to the mailbox when it was empty, I could not remove the first message which said there were not messages on the server. I tried calling clear_mailbox_header but when I did it would not show the messages which were added next. Brennan On Sun, 20 Aug 2006 16:23:23 +0200, Thomas Bruederli <[EMAIL PROTECTED]> wrote: > OK, after digging through your diffs, the only major change I can see, > is that you add the recent_count to the regular message count. Is it > really true that recent messages are not included when asking the IMAP > server for new message count? I cannot confirm this behavior. > > Further on, your changes will definitely cause errors and a huge waste > of performance: > > for ($i=0;$i<=$count+$recent_count;$i++) > $header = $IMAP->get_headers($i, NULL, FALSE); > > This means that the first request for headers will fail because of ID=0. > Then the headers of EACH message in the INBOX will be fetched. Why? I > don't want RoundCube to fetch thousands of message headers if there's > only one recent message. > > And for last, I don't see why the changes to app.js are necessary. What > does the use of a separate variable help for evaluating javascript code? > > Because of the reasons above, I will no commit your patches. > > ~Thomas > > > Brennan Stehling wrote: >> http://trac.roundcube.net/trac.cgi/ticket/1436357 >> >> I diagnosed and resolve the issue, but I do not have Subversion rights. > I would appreciate if a committer could review my changes. >> >> I have posted the patches as comments on the ticket. >> > >> -- Brennan Stehling Offwhite.net LLC [EMAIL PROTECTED]
