I like it. If it works code-wise, then please commit it!!
I just wanted to get the basic functionality in there. Thanks for
improving it Eric and Thomas.
~Brett
Thomas Bruederli wrote:
Nice approach!
Rather than having all config parameters (smpt_server, smtp_port,
smtp_user, smtp_pass) as an array, I suggest to use URLs in
$rcmail_config['smtp_server'].
Example:
$rcmail_config['smtp_server'] = array(
'imap.host1.tld' => smtp.host1.tld',
'imap.host2.tld' => 'smtp://user:[EMAIL PROTECTED]',
'imap.host3.tld' => 'ssl://%u:[EMAIL PROTECTED]:465/CRAM-MD5',
);
(with 'smtp_auth_type' as folder name)
in rcube_smtp.inc simply use parse_url() to get the host-specific
settings, of course with a fallback on the "old" parameters. With this
solution we can get rid of four config properties.
Just my 2 cents.
~Thomas
2007/6/14, Eric Stadtherr <[EMAIL PROTECTED]>:
Brett,
This is a great idea, for which I've already had use! I did a couple
fixes
and enhancements to your patch (it now does smtp-server-specific
usernames
and passwords if desired). Check it out and let me know if it's good. If
so, I'll commit it.