Hey Maximilien, On 9/14/07, Maximilien Cuony <[EMAIL PROTECTED]> wrote: > Here is my first patch for my filter's system. > > I separate my filter system (named mc_filters) from the filter's interface. > > In lib/Filters are the different classes for filter's system (for the moment > only mc_filters and the base class).Filter's system used are stored in the > main.inc.php. > > So.. I'm open to all your remarks, like horribles English's mistakes ;). > > The code is a bit ugly for the moment (I try to not edit your base files and > the CSS so I re-use for ex. the classes for another pages for settings) ^^, > but I will correct this later. > > All is based on the revision 740 of the trunk. > > What do you think about it ? What I have to change ?
Well, basically here is some feedback: 1) Use your own classes, don't add your code to "core" files. 2) Better create this against devel-vnext to make use of autoloading etc.. I couldn't try it yet and won't be able to do so soon - got a working demo or screens? Till _______________________________________________ List info: http://lists.roundcube.net/dev/
