New patch, 30 lines of diff less :)
Thomas Bruederli wrote: > I've tested it but there's something wrong with the indentation of the > folders (see attachment). It happens on Firefox and Safari. Looks like > the float:left of the <div> causes this wrong behavior. But because the > links have display:block it's quite tricky to fix it. Weird, I had no problem on Firefox, but did see it indeed in IE. I added position:absolute, which seems to fix it. Looks good in Firefox, IE7, Safari on W32, but IE somehow doesn't understand something yet. Work in progress. > I guess this works fine. & should be encoded with escape() and therefore > work perfectly as a delimiter. OK, I'll keep that as it is. [... preference getting & saving ...] I've put that in index.php for other functions to use. Is it OK like this? Do we need some more testing of input variables? > And there's one final question: how about unread counts of collapsed > folders? To make it perfect, the collapsed parent folder should show the > cumulated number of unread messages within it's child folders. That would be cool, but would also require a lot more work :) Doable, though. Another thing is the folder icons. Right now I've added two folder icons, but have none for the 'special' folders. My idea is to just use the <div> I added contain a 'plus', 'minus' or 'empty' (or none) icon. Robin Robin --- 8< --- detachments --- 8< --- The following attachments have been detached and are available for viewing. http://detached.gigo.com/rc/KP/dkqReTdD/_1267231.20080616114.patch http://detached.gigo.com/rc/KP/dkqReTdD/_1267231.folder-coll.png http://detached.gigo.com/rc/KP/dkqReTdD/_1267231.folder-expa.png Only click these links if you trust the sender, as well as this message. --- 8< --- detachments --- 8< ---
_______________________________________________ List info: http://lists.roundcube.net/dev/
