Hi!
0.2-beta is a great upgrade. While leafing through the new config
options available in main.inc.php, it occurred to me that the upgrade
process could be simpler yet. If I can avoid making changes to the
shipped main.inc.php, then when upgrading I can always replace it with
the new version as shipped (taking care to see what's new, of course).
This is easy, if the shipped main.inc.php ends like so:
--- /usr/pkg/share/examples/roundcube/main.inc.php.dist 2008-09-21
23:24:14.000000000 -0400
+++ /etc/roundcube/main.inc.php 2008-09-24 15:00:31.000000000 -0400
@@ -377,5 +377,7 @@
// Display attached images below the message body
$rcmail_config['inline_images'] = TRUE;
+include_once('main-local.inc.php');
+
// end of config file
?>
Then, if the sysadmin creates main-local.inc.php, any settings it
contains will override the defaults, and main.inc.php can be treated
as read-only if the sysadmin so desires. And for some uses, at least,
that makes it easier to compare the old and new main.inc.php to see
which new settings are available.
(Same idea applies to db.inc.php.)
I can't say I've noticed any sort of performance hit as a result of
this, and I'd be surprised if there were much of one, but my
environment isn't terribly high-load and I haven't profiled anything.
With this change, working in the way I'm talking about is entirely
optional; nobody has to change how they do things unless they want to.
Would this change be acceptable in RoundCube?
- Amitai
_______________________________________________
List info: http://lists.roundcube.net/dev/
