On Mon, 6 Apr 2009 09:42:27 -0500, chasd <[email protected]> wrote: > On Apr 4, 2009, at 7:09 AM, Frank van den Brink wrote: > >> Heya! >> >> I implemented this by making some small changes to >> roundcubemail/program/include/rcmail.php to load a separate >> timezones.inc >> file from the language's localization directory. > > Assuming that someone that uses a specific language is physically > located in a specific timezone is not a good idea. > It is expedient, and may be a good assumption in a majority of cases. > Still not a good choice that can't be easily overridden. > As can be seen in the patch, that is not what the change entails. It only removes the hardcoded timezone names, and instead loads these from a "timezones.inc" file in the locale directory of the user-selected language, similar to how "labels.inc" and "messages.inc" are used.
It changes nothing about how a user's timezone is determined. _______________________________________________ List info: http://lists.roundcube.net/dev/
