On Fri, May 8, 2009 at 10:49, Robin Elfrink <[email protected]> wrote: > Hi, > > I've been working on #1485659, and found that it's basically a duplicate > of #1484678. > > The issue is atomicness of session variables. > > I have a patch in #1485659 that solves the problem, but not completely.
The solution you committed seems to solve the issue quite well for now. > > What we need, in my opinion, is a per-variable row in the session table. > And, if possible, reads/writes per variable. Maybe even replace all > references to $_SESSION[] with functions like rcube_sess_get() and > rcube_sess_set() or something like that. I'm not a big fan of this approach. It requires changes to the db-schema every time we introduce a new session var and I'm sure you'll forget to update the schema while you're programming. If we cannot use the $_SESSION vars directly anymore we're at the point where we should implement the entire session handling by ourselves and omit the php session stuff. This is certainly not preferable. ~Thomas _______________________________________________ List info: http://lists.roundcube.net/dev/
