On Jun 1, 2009, at 11:25 AM, Eric Stadtherr wrote:

> // Workaround for mail agents that include Windows-1252 characters
> // in text advertised as ISO-8859-1
> if ($from == "ISO-8859-1" && preg_match("/[\x80-\x9F]/", $str))
> $from = "WINDOWS-1252";

Since $str can be very large, isn't there a performance / resource  
penalty to the preg_match in order to compensate for a mistake that  
is outside of RoundCube ?

Yes, this may help you with this particular sender, but the potential  
is for each and every RoundCube user to pay this performance price  
processing each and every message. Maybe my old-school sensibilities  
are too worried about CPU time with today's CPUs.


-- 
Charles Dostale
System Admin - Silver Oaks Communications
http://www.silveroaks.com/
824 17th Street, Moline  IL  61265

_______________________________________________
List info: http://lists.roundcube.net/dev/

Reply via email to