Hi, I globally agree with modifications you bring to the plugin (especially move-on-edit which is, -at least for myself-, a logical behaviour) I seen that Roland, you reverted the readonly to FALSE, I don't know for what purpose but it's benefic, as it's allow user to delete some automatic contacts (ex: wrong or no longer used address).
just one point : > (i) Removed installer (got a http 500 error). I think we do not expect to > much if we only provide the sql scripts. > Well, maybe the kind of installer I made is not the real solution and not working very well. But I think a raw sql script is a bit to raw... roundcube is quite easy to install. It's surprising me a bit that such a problematic didn't happened with other plugins, I'm really not familliar with the project but do you plan to allow a kind of installation hooks for plugins ? For the 500 error, it may be due to the fact you put long SQL comments (/* spam egg */) which the installer didn't handle. I integrated all of your (Vladislav & Roland) edits, see latest release : http://crapouillou.net/~jocelyn/ressources/roundcube/ Regards, Jocelyn P.S : please if you do changes, attach patches instead of/along with zip, it's easier to see/apply modifications, thanks ! > #3 General > > (i) I defined the automatic addressbook as readonly *). I think it should > not be possible to add manually created items to the automatic addressbook. > Does anyone have a clue how to disable the import button aswell? > (ii) If a automatically added contact is edited, the contact is moved to > the default addressbook and removed from the automatic addressbook. I think > when a user edits a contact, we can assume that it is accepted as a > permanent personal contact. My code modifications presume that the default > addressbook source is always "0". Is this right or would it be better to > use a configurable value? > > Regards, > Roland > > *) May be this works only because app.js is inconsequent at this point. It > disables the add button, but the import button is still enabled. Also it is > still possible to edit a contact, which is inconsequent but necessary for > my purpose. _______________________________________________ List info: http://lists.roundcube.net/dev/
