On Wed, 07 Oct 2009 08:56:24 +0200, "A.L.E.C" <[email protected]> wrote:
> 1. threads support detection and thread algorithm auto-selection. I
> think 'imap_thread_algorithm' should be set automatically to the best
> from those supported by server (REFS, REFERENCES, ORDEREDSUBJECT). It
> means if e.g. server supports REFS and ORDEREDSUBJECT we should use
> REFS. Does anybody need ORDEREDSUBJECT if he's server supports
> REFERENCES? Also see manage_folders.inc for:
> $IMAP->get_capability('thread=references');
This is a good idea.
> 2. Don't use massage_sort_col='default'. Since we have 'index_sort'
> option. Messages are sorted by message index if message_sort_col='date'.
> We don't need this 'default' stuff also because THREAD command returns
> messages sorted by date.
message_sort_col='default' <=> (index_sort == true &&
message_sort_col='date')
Exactly the same thing, just with a different name, before index_sort was
added.
Assume imap_thread_algorithm='REFS'.
Sometimes you want to sort by the date of the last message received in a
thread (i.e. index_sort=true, message_sort_col='date') and sometimes you
want to sort by the date of the first message in a thread (i.e.
index_sort=false). At present the user must go into settings to turn
index_sort on/off which is unintuitive. This is the reason I argued for a
4-state Date column.
> 5. In mail steps use short $IMAP instead of
> rcmail::get_instance()->imap->threading. Just for better readability.
Agreed, but rcmail.php says:
* @todo Remove global $IMAP
and
// set global object for backward compatibility
$GLOBALS['IMAP'] = $this->imap;
?
Chris
_______________________________________________
List info: http://lists.roundcube.net/dev/
