Am Mittwoch 01 Dezember 2010, um 21.22:03 schrieb Andreas Dick:
> On Tue, 30 Nov 2010 07:35:14 -0000, Roundcube Webmail wrote:
> > #1487314: RC in a Frame do not work in 0.5-beta
> >
> > -------------------------+-----------------------------------------------
> > ---
> >
> > Reporter: andudi | Type: Bugs
> >
> > Status: closed | Priority: 5
> >
> > Milestone: later | Component: User Interface
> >
> > Version: 0.5-beta | Severity: normal
> >
> > Resolution: worksforme | Keywords: frame dyndns
> >
> > -------------------------+-----------------------------------------------
> > ---
> >
> > Changes (by alec):
> > * status: new => closed
> > * resolution: => worksforme
> >
> > Comment:
> > Works for me. Move noframes tag outside of frameset. Also make sure
> >
> > that
> >
> > main and frame pages are using the same protocol. It will not work
> >
> > if main
> >
> > page uses http and frame uses https.
>
> Hei Alec
> I digged further and found: the problem occures only in Firefox
> (Windows XP and Ubuntu 10.10), and it works well in IE, Konqueror and
> Reqonk...
> Again what I observing: Showing email do NOT work if RC 0.5-beta is
> runned in DynDNS Webhop.
> With RC 0.4.2 it works still well even with Firefox, and it works well with
> the devel-addressbook (rev 4300) and with the demo (version?) at
> http://mail4us.net/?_redirect=&_task=mail&_action=plugin.wrapper&_screen_wi
> dth=1280&_default_width=1000&skin=default
>
> so, it seems to be hard to debug.. I suggest a JS problem and I would try
> to digg in the code, but I have no start point yet.
hei alec
update:
first I found that if I replace program/js/app.js from version 0.4.2, it works
fine.
then I tried to replace just parts of the 0.4.2 (working) code to localize the
problem.
Like this I found that if I revert the changes shown below as unified diff, the
problems are gone as well!
I suggest that the url building is the problem, but I am not that good with
JS... I hope you could have an idea what could be wrong, even if it concerns
only frames and the JS of firefox. maybe other browsers can handle it or their
JS implementation is different?
what could I test else?
thanks for help
Andreas
********************************************************************
diff -u roundcubemail-0.4.2/program/js/app.js.src roundcubemail-0.5-
beta/program/js/app.js.src
--- roundcubemail-0.4.2/program/js/app.js.src 2010-11-23 20:20:30.000000000
+0100
+++ roundcubemail-0.5-beta/program/js/app.js.src 2010-11-17
10:01:25.000000000 +0100
....
@@ -1726,27 +1803,28 @@
if (!id)
return;
- var add_url = '',
- target = window,
- action = preview ? 'preview': 'show';
+ var target = window,
+ action = preview ? 'preview': 'show',
+ url =
'&_action='+action+'&_uid='+id+'&_mbox='+urlencode(this.env.mailbox);
if (preview && this.env.contentframe && window.frames &&
window.frames[this.env.contentframe]) {
target = window.frames[this.env.contentframe];
- add_url = '&_framed=1';
+ url += '&_framed=1';
}
if (safe)
- add_url = '&_safe=1';
+ url += '&_safe=1';
// also send search request to get the right messages
if (this.env.search_request)
- add_url += '&_search='+this.env.search_request;
+ url += '&_search='+this.env.search_request;
- var url =
'&_action='+action+'&_uid='+id+'&_mbox='+urlencode(this.env.mailbox)+add_url;
if (action == 'preview' && String(target.location.href).indexOf(url) >=
0)
this.show_contentframe(true);
else {
- this.set_busy(true, 'loading');
+ if (!this.env.frame_lock) {
+ (parent.rcmail ? parent.rcmail : this).env.frame_lock =
this.set_busy(true, 'loading');
+ }
target.location.href = this.env.comm_path+url;
// mark as read and change mbox unread counter
_______________________________________________
List info: http://lists.roundcube.net/dev/
BT/8f4f07cd
