Hello there :D
I'm a new subscriber in the dev-mailing list, my name is Tilman
Stremlau, I'm 17 years old and I use roundcube as my main mail-client
since I try to get away from Google Mail. So my aim is to help
developing the project and some plugins (my fist one is html5_notifier
http://www.roundcubeforum.net/7-third-party-contributions/46-api-based-plugins/8836-new-plugin-html5_notifier-desktop-notification.html
).
There is a point I am not happy with:
The implementation of the hook "new_messages". The hook is just fired,
if a new mail arrived in the current opened mailbox.
On my opinion is this very useless for plugins. It would be better if
it is fired every time a new message arrives. Check if it's the current
mailbox could be done in the plugin itself - if necessary.
Changing the Code:
check_recent.inc line 37
" if ($mbox_name == $current && ($status =
$IMAP->mailbox_status($mbox_name))) {"
to
" $status = $IMAP->mailbox_status($mbox_name);
if ($status & 1)
{
if ($RCMAIL->config->get('focus_on_new_message', true) &&
$mbox_name == $current)
{
$OUTPUT->command('new_message_focus');
}
// trigger plugin hook
$RCMAIL->plugins->exec_hook('new_messages', array('mailbox' =>
$mbox_name));
}
if ($mbox_name == $current && $status)
{"
deleting line 73-78 (old hook call)
Another thing: The Class-File html.php
The complete structure is not perfect. I could use html_checkbox::a();
to create a link and there are many unnecessary sprintf etc.
If you want, I rewrite the complete class and send it as attachment to
you. This week I have enought time :D
All in all Roundcube is the best webclient I ever tested and I love it!
Big admission to the developers, you did a good job!
Regards,
Tilman Stremlau
P.S. Sry for my bad english, I am not the best in speaking english, but
I try to do my best :D I'm not unhappy about corrections, otherwise I
don't get better :D
_______________________________________________
List info: http://lists.roundcube.net/dev/
BT/8f4f07cd
