On Sat, Jan 7, 2012 at 2:11 PM, Thomas Bruederli <[email protected]>wrote:
> Rob Sheldon wrote: > > Hi, > > > > Finally decided to get memcached up and running with Roundcube -- > > awesome work there. > > > > I ran into a problem getting it to go at first though. Turned on all > > the logging in memcache and found this relevant bit: > > > > [...] > > > > In rcube_session.php, I mucked about with the first line of > > mc_destroy(), changing it to: > > > > $ret = $this->memcache->delete($key, 0); > > > > ...which makes everything happy, despite being incorrect. > > I don't have a problem adding this to your code and becoming "incorrect" > unless anybody else reports problems with that change. PHP usually doesn't > complain about additional arguments passed to a function call, only if > there are too few arguments passed. > > +1 for the change: http://docs.php.net/manual/en/memcache.delete.php This states that it's not recommend to use the timeout paramter, but using 0 is safe and shouldn't break anything anywhere else. Till
_______________________________________________ List info: http://lists.roundcube.net/dev/ BT/8f4f07cd
