On 03/13/2013 07:51 PM, Jan Fader wrote:
> Hi Roundcube-Devs
>
> I have created a patch for trac-ticket #1488732 and testet it successfully
> on my instance roundcube.git.
>
> Could you please take a look at this new feature, provide suggestions if
> needed or include it into your maintree?
Please, create pull request on github.
> +$labels['show_fullemail'] = 'Show full email along with display name';
Actually, the word "full" is not needed. I'd use 'Show email address
along with display name'. Remove underscore from the label name.
> + $user_prefs=$RCMAIL->user->get_prefs();
> + if ($user_prefs['message_show_fullemail']) {
Just use $RCMAIL->config->get('message_show_email'), no need to call
get_prefs(), preferences are already merged with config.
> + $address = html::a(array(
> + 'href' => 'mailto:'.$mailto,
> + 'onclick' => sprintf("return %s.command('compose','%s',this)",
> JS_OBJECT_NAME, JQ($mailto)),
> + 'title' => $mailto,
If we display the address, title is not needed, right?
--
Aleksander 'A.L.E.C' Machniak
LAN Management System Developer [http://lms.org.pl]
Roundcube Webmail Developer [http://roundcube.net]
---------------------------------------------------
PGP: 19359DC1 @@ GG: 2275252 @@ WWW: http://alec.pl
_______________________________________________
Roundcube Development discussion mailing list
dev@lists.roundcube.net
http://lists.roundcube.net/mailman/listinfo/dev
